Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Field Number - align readonly & disabled state with design #915

Open
4 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Feb 14, 2024 · 0 comments · May be fixed by #1152
Open
4 tasks done
Tracked by #452

Input Field Number - align readonly & disabled state with design #915

thrbnhrtmnn opened this issue Feb 14, 2024 · 0 comments · May be fixed by #1152
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Feb 14, 2024

Description / User story

The readonly state of the Input Field Number should not include the stepper buttons according to design.
We had this status in the past already, but accidentally added the stepper buttons again to the readonly state with #719 .

Also in disabled state the color of the stepper button icons should be grey instead of blue.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • When in readonly state, the Input Field Number does not display any stepper buttons and the value can not be adjusted.
  • When in disabled state, the stepper buttons of the Input Field Number have the same color as defined in design (in all stepper variants) - While fixing this, the stepper buttons should also be checked in other states in dark mode, as they have changed in design and are now #fff
  • When in disabled state, the input/value color has the same color as defined in design

Additional information

  • ...

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added 🎓 junior issue Good for juniors ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Feb 14, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Number Input - align readonly state with design Number Input - align readonly & disabled state with design Feb 19, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Number Input - align readonly & disabled state with design Input Field Number - align readonly & disabled state with design Mar 26, 2024
@bar-tay bar-tay self-assigned this Aug 27, 2024
@bar-tay bar-tay linked a pull request Sep 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants