fix(storybook): Input field number adjustment #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bar-tay
force-pushed
the
fix/915_input-number-fix
branch
from
a337e1e to
1eccc8e
Compare
bar-tay
changed the title
bar-tay
added
the
🦹 needs:reviewers (code)
bar-tay
force-pushed
the
fix/915_input-number-fix
branch
from
e1326dc to
4396843
Compare
ashk1996
approved these changes
Sep 19, 2024
thrbnhrtmnn
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Hey @bar-tay , here are my findings:
- The unit color is not correct in disabled and in error state
- The widths are all correct now, but it seems like the height in the MD is wrong now for the vertical stepper variant
- When a unit is shown or when stepperVaraint = Split, the readonly state now shows some outline or border around the user input container
thrbnhrtmnn
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #915
closes #932
closes #933
closes #1117