Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unstyled form component to check basic validation for text input components #596

Closed
4 tasks done
Tracked by #990
thrbnhrtmnn opened this issue Nov 15, 2023 · 1 comment · May be fixed by #977
Closed
4 tasks done
Tracked by #990

Create unstyled form component to check basic validation for text input components #596

thrbnhrtmnn opened this issue Nov 15, 2023 · 1 comment · May be fixed by #977
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Nov 15, 2023

Description / User Story

We want to test the basic validation of all our FormComponents that will be part of Release 1.0. As we do not have a form component yet, we have to create an unstyled form component and then implement a logic into it to check if the Text input components within the form that have the prop "required" = TRUE also have a value. The form component also makes use of a Submit Button in form of a TextButton (or IconButton) component to start the validation.


Requirements

  • none

Acceptance Criteria

  • Unstyled FormComponent has been build
  • A Text Input component with required=true has been placed in the form component
  • The form can be submitted via a TextButton component
  • After submit, the FormComponent will check if all required components within the form have a value and if not throw an error (the components with missing values also should display the error state)

Background information

  • It can be the case, that this task will reveal issues with our form components, these issues should be fixed within separate tasks.
  • Error states are currently a class. They will not be set automatically without a change.
  • We will add follow-up issues to add these changes also to other form components
  • We will also have a follow-up task to check more then the "required=true" validation for our components
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Nov 15, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⌨️ dev issue Task is for developers label Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⭕ core team issue This is for the core team and should not be done by contributors label Jan 5, 2024
@thrbnhrtmnn thrbnhrtmnn modified the milestones: Release 1.0, Evaluate Validation in React Feb 12, 2024
@thrbnhrtmnn thrbnhrtmnn modified the milestones: LGL Preperation, Release 1.0 Feb 21, 2024
@angsherpa456 angsherpa456 self-assigned this Feb 23, 2024
@thrbnhrtmnn thrbnhrtmnn added the 📋 task::ready Task is ready to be picked up or planned in label Feb 29, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Create unstyled form component to check basic validation for form components Create unstyled form component to check basic validation for text input components Feb 29, 2024
@thrbnhrtmnn thrbnhrtmnn removed this from the Release 1.0 milestone Mar 7, 2024
@thrbnhrtmnn
Copy link
Contributor Author

As discussed yesterday, this issue can be closed. The outcome has been documented in #990 , where we will finalise the implementation for the text input before then tackling the other form components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers 📋 task::ready Task is ready to be picked up or planned in
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants