feat(ui-library): forms with&without slot and simple manual validation(#596) #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added lit-analyzer to compile step and updated vs code extensions * updated lit and added github worklflow * updated path * pathes stuff * github jobs renaming * ignore analyze in the pipeline * test the attribute * removed comment * dont update lit * dont update lit
…lder text (#719) * fix the numberinput to always display stepper before, stepper would disappear if you set the unit to undefined or readonly to true. this was because of conditonal rendering conditions. this fixes the problem by extracting the stepper render function outside the rendering condition of unit inside the input. * display the placeholder for default value the default value in not undefined, so it would hinder and unable the placeholder to be visible. this adds a condition to render the placeholder if it's not the default value * adds test for disappearing stepper buttons --------- Co-authored-by: Muhammad Usman <bcs.12.16@gmail.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
…loading to icons and run test against build (#718) * commit before passing * got icons chunked * fix eslint issue
- deleting old contribute file, so a new one that is linked in the About section of the repo can be added Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Adding a new contribute file, which will also be displayed under about on the repo starting page Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
fixed links to: - contribution.md - code of conduct md - discussion board Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Removing the duplicate contribution.md file, as the correct file now is located outside of the doc folder. This change was done, to comply with the the GitHub Community Standards. Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
- Updated year in license.md to 2023-2024 - Also fixed an error, where B01LER was not replacing the full placeholder Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Updated the labels under Tipps to find issues, and added the "core team issue" label, which was newly introduced. Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* feat(storybook): added Counter Stories --------- Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com> Co-authored-by: David Kennedy <david.a.kennedy@accenture.com>
* fix(tokens): moves and renames label tokens are renamed to component name and moved into component sets * feat: adds FormLabel to style-dictionary.config * fix: apply renamed tokens to forms.css * feat(tokens) moving label colors to CMP forms.label.[state] stays in SEM but will not be applied onto component anymore * fix: replaces Forms.Label with Forms.FormLabel Also fixes LabelNextToControl colors in multiple files. * fix(tokens): move nextToConrol from SEM to CMP also renames to InlineLabel * fix: fix occurances of labelNextToControl This typotoken moved to CMP and was renamed to ..LabelInline.Typography. * moved checkbox css changes to component css file and deleted global * removed comma * readded correct tokens to checkbox * fixed radio css file --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com>
* fix(tokens): renames textarea minHeight * fix: apply new tokennames at Textarea css --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com>
* feat(storybook): added form Label Story * fix(storybook): added line break * fix(storybook): changed some little text and stories after review * fix(storybook): fixed some text changes after review --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* fix(storybook): added some changes after review * fix(storybook): added changes after review --------- Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* we need a relative path here * fix for range slider only * fixed some imports and deactivated icon tests * now all tests run against build * prod fix of example app
* added dependencies to story for buttons * fix for all
* icon uses correct event handling for blrClick - fixes password * compile issues
* feat: updates ItemSpacings to have different values per size * remove configuration --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* feat(storybook): initial commit * feat(storybook): add radio group docs * fix(ui): add feedback * fix(storybook): change folder name * fix(storybook): filenaming * fix(storybook): import issues * fix(storybook): import issue --------- Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
* feat(storybook): added argTableTypes * feature(storybook): added toggle-switch story * feature(storybook): added various stories * fix(storybook): added changes after review and add name property to component * fix(storybook): change story property order * fix(storybook): added changes after review * fix(storybook): another changes after review * fix(storybook): added changes after review
* fixes tooltip tokens * apply new token names on tooltip-bubble/index.css * Adds tooltip elevation and typo tokens * fix tooltip tokens --------- Co-authored-by: David Kennedy <127498135+davidken91@users.noreply.github.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
…ase Property Names (#939)
* fix(ui-library): harmonized property naming in textButton and all relevant files
* fix(ui-library): added some changes after review * fix(ui-library): adapted action property naming in the story * fix(ui-library): harmonized naming in argTypes
* - renamed doc folder to docs - updated links between documentation files - updated "Get Started" section in CONTRIBUTING file * docs: fix typos * docs: remove empty lines Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove empty lines and premature sentence wrapping Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: removing new line and sentence wrapping Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove new lines and sentence wrapping Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove new lines Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove new lines Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove new lines Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove new lines Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove empty lines Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: remove empty lines Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* docs(README): update image link Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: update repo links Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: update repo links Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: update repo links Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: update repo links Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: update repo links Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* Feat(tokens): applied tokenchanges from v2 * updated tokens * try fix tokens:generate on CI * try fix tokens:generate on CI * made gitignore not needing to know theme names * try fix tokens:generate on CI * try fix tokens:generate on CI * all folders lower case * fix number names --------- Co-authored-by: larserbach <larserbach@users.noreply.github.com>
* docs: update figma links for new release Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> * docs: update figma link Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> --------- Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
* feat(ui-library): add ts-lit plugin with rules * feat(ui-library): use same settings for vs code
* fix(ui-library): adding Figma and Tokens Studio documentation to readme * fix(ui-library): removing usage section from readme * fix(ui-library): adding yarn start note * fix(ui-library): providing link to Getting Started section in Figma * fix(ui-library): adding Tokens Studio installation guide to readme * fix(ui-library): adding build instructions to readme * fix(ui-library): linking readme to deployment.md file * fix(ui-library): updating Deployment.md file * fix(ui-library): adding notes Deployment.md file to explain each section * fix(ui-library): adding Support section to Deployment.md file * fix(ui-library): adding anchors to Figma and Tokens Studio in Readme file * fix(ui-library): removing 'next' step from readme * fix(ui-library): removing getting started paragraph * fix(ui-library): removing example js app run instructions * fix(ui-library): fix readme formatting * fix(ui-library): updating table of contents * fix(ui-library): updating bug report and feature requests urls * fix(ui-library): updating package.json metadata with new repo name * fix(ui-library): updating pipeline files with new repo name * fix(ui-library): updating Figma file links * fix(ui-library): updating figma link in getstarted.md
* docs(general): add documentation how to change icon set * docs(general): fix a typo * docs(general): resolved PR comments * docs(general): added Change Icons section * docs(general): fixed hyperlinks layout * docs(general): fixed typos * docs(general): 921 removed leftovers after rebase
- added open door meeting - updated Figma access description in access checklist - added "Onboarding" to project management onboarding checklist headline - added Design, Developers and Product & Project Management Anchors to ToC - removed Sales Deck Contributor page from project management onboarding checklist Signed-off-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com> Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
angsherpa456
changed the title
- render util does not produce malformed HTML anymore when `props` or `htmlAttributes` are empty
* fixed icon size behaviour * fixed unit tests * fix(ui-library): fixed default icon sizes settings for select, text/number input and tabbar
angsherpa456
force-pushed
the
feat/596_create-basic-form
branch
2 times, most recently
from
e2f4e68
to
9b8d23f
Compare
angsherpa456
force-pushed
the
feat/596_create-basic-form
branch
from
d3a348d
to
4482233
Compare
angsherpa456
force-pushed
the
feat/596_create-basic-form
branch
from
4482233
to
d081f73
Compare
4 tasks
ChristianHoffmannS2
force-pushed
the
develop
branch
2 times, most recently
from
358f467
to
99c0c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #596