-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor event typing #926
Conversation
}; | ||
export type BlrFocusEvent = CustomEvent<BlrFocusEventDetail>; | ||
export const BlrFocusEventName = 'blrFocus'; | ||
export function createBlrFocusEvent(detail: BlrFocusEventDetail): BlrFocusEvent { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice approach 👍
d850461
to
ebc55a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # packages/ui-library/src/components/checkbox/index.ts # packages/ui-library/src/components/select/index.ts # packages/ui-library/src/components/text-input/index.ts # packages/ui-library/src/components/textarea/index.ts
df921d7
to
6503874
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.