Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event typing #926

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Refactor event typing #926

merged 2 commits into from
Feb 19, 2024

Conversation

remmycat
Copy link
Contributor

No description provided.

};
export type BlrFocusEvent = CustomEvent<BlrFocusEventDetail>;
export const BlrFocusEventName = 'blrFocus';
export function createBlrFocusEvent(detail: BlrFocusEventDetail): BlrFocusEvent {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach 👍

angsherpa456
angsherpa456 previously approved these changes Feb 16, 2024
Copy link
Contributor

@angsherpa456 angsherpa456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	packages/ui-library/src/components/checkbox/index.ts
#	packages/ui-library/src/components/select/index.ts
#	packages/ui-library/src/components/text-input/index.ts
#	packages/ui-library/src/components/textarea/index.ts
Copy link
Contributor

@angsherpa456 angsherpa456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remmycat remmycat merged commit fc426e6 into develop Feb 19, 2024
3 of 4 checks passed
@remmycat remmycat deleted the refactor/event-typing branch February 19, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants