feat(ui-library): 938 update component names #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veilvokay
force-pushed
the
feat/938_update-component-names
branch
2 times, most recently
from
74ed3f8 to
ae10999
Compare
thrbnhrtmnn
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Hey @veilvokay , I had a look at this branch in Storybook and the documentation mostly looks good. I only found a few points, most of which are already wrong on the current develop. I would like if you could quickly fix them within this branch.
Also I looked at the docs in the repo and left a comment for the README file.
For all other files I would like you to ask another dev for the review. In my opinion we can already start this, and open this PR :-)
packages/ui-library/src/components/button-icon/index.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui-library/src/components/button-group/index.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui-library/src/components/button-text/index.stories.ts
Outdated
Show resolved
Hide resolved
packages/ui-library/src/components/form-caption-group/index.stories.ts
Outdated
Show resolved
Hide resolved
thrbnhrtmnn
requested changes
Mar 4, 2024
packages/ui-library/src/components/button-icon/index.stories.ts
Outdated
Show resolved
Hide resolved
faselbaum
added
the
🦹 needs:reviewers (code)
ChristianHoffmannS2
previously approved these changes
Mar 11, 2024
davidken91
previously approved these changes
Mar 11, 2024
faselbaum
previously approved these changes
Mar 11, 2024
faselbaum
removed
the
🦹 needs:reviewers (code)
larserbach
dismissed stale reviews from faselbaum, davidken91, and ChristianHoffmannS2
via
4dd06a5
veilvokay
force-pushed
the
feat/938_update-component-names
branch
from
f8fc06a to
36f5b17
Compare
ChristianHoffmannS2
approved these changes
Mar 12, 2024
faselbaum
approved these changes
Mar 12, 2024
ChristianHoffmannS2
pushed a commit
that referenced
this pull request
Mar 26, 2024
* feat(ui-library): #938 updated Button Text * feat(ui-library): #938 updated Button Icon * feat(ui-library): #938 updated Input Number * feat(ui-library): #938 updated Input Field Text * feat(ui-library): #939 changed Input Number -> Input Field Number * docs(general): #938 updated README.md with new component names * feat(ui-library): #938 resolved PR comments * feat(ui-library): #938 resolved PR comments * feat(ui-library): #938 small fix after rebase
ChristianHoffmannS2
pushed a commit
that referenced
this pull request
Mar 26, 2024
* feat(ui-library): #938 updated Button Text * feat(ui-library): #938 updated Button Icon * feat(ui-library): #938 updated Input Number * feat(ui-library): #938 updated Input Field Text * feat(ui-library): #939 changed Input Number -> Input Field Number * docs(general): #938 updated README.md with new component names * feat(ui-library): #938 resolved PR comments * feat(ui-library): #938 resolved PR comments * feat(ui-library): #938 small fix after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.