Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-library): harmonized property naming in loader and fixed misse… #979

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

JpunktWpunkt
Copy link
Contributor

harmonized property naming of loader and fixed missed sizeVariant in js example text-button
related to #873

Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in Storybook, cant evaluate the other parts though

Copy link
Contributor

@angsherpa456 angsherpa456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thrbnhrtmnn thrbnhrtmnn merged commit 491bd6b into develop Mar 8, 2024
3 of 4 checks passed
@thrbnhrtmnn thrbnhrtmnn deleted the fix/873-loader-harmonized-property-naming branch March 8, 2024 08:27
ChristianHoffmannS2 pushed a commit that referenced this pull request Mar 26, 2024
…d sizeVariant in js example text-button (#979)

Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
ChristianHoffmannS2 pushed a commit that referenced this pull request Mar 26, 2024
…d sizeVariant in js example text-button (#979)

Co-authored-by: Thorben Hartmann <122102805+thrbnhrtmnn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loader - Ensure Consistency between Storybook Documentation and Codebase Property Names
4 participants