Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-library): prop alignment select (872) #983

Merged
merged 3 commits into from
Mar 8, 2024
Merged

fix(ui-library): prop alignment select (872) #983

merged 3 commits into from
Mar 8, 2024

Conversation

bar-tay
Copy link
Contributor

@bar-tay bar-tay commented Mar 6, 2024

No description provided.

@bar-tay bar-tay linked an issue Mar 6, 2024 that may be closed by this pull request
Select - Ensure Consistency between Storybook Documentation and Codebase Property Names #872
Closed
6 tasks
angsherpa456
angsherpa456 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@angsherpa456 angsherpa456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faselbaum faselbaum force-pushed the fix/872-prop-alignment-selct branch from d813366 to 1662c8e Compare March 8, 2024 09:07
@ChristianHoffmannS2 ChristianHoffmannS2 changed the title Fix/872 prop alignment selct fix(ui-library) prop alignment select (872) Mar 8, 2024
@ChristianHoffmannS2 ChristianHoffmannS2 changed the title fix(ui-library) prop alignment select (872) fix(ui-library): prop alignment select (872) Mar 8, 2024
@ChristianHoffmannS2 ChristianHoffmannS2 merged commit 6470282 into develop Mar 8, 2024
3 of 4 checks passed
@ChristianHoffmannS2 ChristianHoffmannS2 deleted the fix/872-prop-alignment-selct branch March 8, 2024 11:22
ChristianHoffmannS2 added a commit that referenced this pull request Mar 26, 2024
@bar-tay @ChristianHoffmannS2
fix(ui-library): prop alignment select (872) (#983)
74edadc 
* fix(Storybook): aligne props

* fix(Storybook): aligne props

---------

Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
ChristianHoffmannS2 added a commit that referenced this pull request Mar 26, 2024
@bar-tay @ChristianHoffmannS2
fix(ui-library): prop alignment select (872) (#983)
4c75d19 
* fix(Storybook): aligne props

* fix(Storybook): aligne props

---------

Co-authored-by: Christian Hoffmann <112889877+ChristianHoffmannS2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianHoffmannS2 ChristianHoffmannS2 ChristianHoffmannS2 approved these changes

@JpunktWpunkt JpunktWpunkt JpunktWpunkt approved these changes

@angsherpa456 angsherpa456 angsherpa456 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select - Ensure Consistency between Storybook Documentation and Codebase Property Names
4 participants
@bar-tay @angsherpa456 @JpunktWpunkt @ChristianHoffmannS2