-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Best Practices Changes #41
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 73.16% 73.16%
=======================================
Files 11 11
Lines 1565 1565
=======================================
Hits 1145 1145
Misses 351 351
Partials 69 69 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reasoning behind exempting the What shared resources are you referring to? |
@Jdubrick I meant the two links in the comment :D For the included checks it makes sense to me. But what was the criteria of selecting these two checks instead of others listed here: https://clomonitor.io/docs/topics/checks/ |
@thepetk Oh I understand now! The reason for choosing those two checks is because most of the others don't apply to this repository, we can view all the ones for Alizer here: https://clomonitor.io/projects/cncf/devfile#alizer. For the Cleaner tasks it includes the |
What does this PR do?
This PR adds the OpenSSF Best Practices Badge to the README file as well as exempts this repository from the ArtifactHub and License Scanning checks for the CLOMonitor. These checks are being exempted from almost all of our repositories.
Which issue(s) does this PR fix
fixes devfile/api#1384 (all but scorecard that is going to be added later)
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer