-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove vscodetask and vscodelaunch, deprecate project.github #349
Conversation
74bfc92
to
4d71398
Compare
Signed-off-by: Stephanie <yangcao@redhat.com>
4d71398
to
7263e83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👍 on the changes but I'm not sure they're fully complete -- on the CRDs side, this poses a bit of a problem in the conversion functions (as the removed command types obviously cannot be converted to v1alpha2
).
The easiest approach is to remove vscode-related tasks from the conversion tests -- I can help implement that if you would like.
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
I opened yangcao77#1 into the PR branch to remove vscode tasks from conversion tests. It's also worth noting that this PR effectively removes the tasks from |
Remove vscode conversion
Signed-off-by: Stephanie <yangcao@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we should get approval from @l0rd and/or @davidfestal before merge
Test updates LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this PR but this was discussed and agreed during last Cabal so +1 to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, elsony, l0rd, mmulholla, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stephanie yangcao@redhat.com
What does this PR do?
remove vscodetask and vscodelaunch, deprecate project.github
remove vacodetask & vacodelaunch related tests and sample devfiles
What issues does this PR fix or reference?
#340
#344
Is your PR tested? Consider putting some instruction how to test your changes
Docs PR