Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments so dockerfiles can be updated by update-base-images #46

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

SDawley
Copy link
Contributor

@SDawley SDawley commented Dec 5, 2022

Changes for eclipse-che/che#21575
Set the dockerfiles to use a specific tag and added the commented html line which should allow the update-base-images action to keep them up to date.

Signed-off-by: sdawley <sdawley@redhat.com>
universal/ubi8/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Nick Boldt <nboldt@redhat.com>
…based or semver-sequential, and therefore cannot be ordered

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Dec 7, 2022
@nickboldt nickboldt merged commit 54aed0d into devfile:main Dec 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt, SDawley

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants