Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding contribution guidelines and dco #25

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

mike-hoang
Copy link
Contributor

Signed-off-by: Michael Hoang mhoang@redhat.com

What does this PR do / why we need it:

Outlines the contribution guidelines for the devfile-web repo.

Which issue(s) this PR fixes:

devfile/api#772, devfile/api#878

PR acceptance criteria:

  • Unit Tests
  • E2E Tests
  • Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Hoang <mhoang@redhat.com>
@nx-cloud
Copy link

nx-cloud bot commented Aug 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7e4debb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mike-hoang, schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mike-hoang,schultzp2020]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mike-hoang mike-hoang merged commit fe13643 into devfile:main Aug 29, 2022
@mike-hoang mike-hoang deleted the docs branch November 16, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants