Begin process of deprecating previous role and rolebinding functionality

The default way to provision roles and rolebindings in DevWorkspace
namespaces was by creating roles and bindings with static names. This
needs to be extended and so the previous way of provisioning needs to be
safely deprecated.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>

pkg/cache/cache.go

@@ -75,10 +75,10 @@ func GetCacheFunc() (cache.NewCacheFunc, error) {
 			Label: secretObjectSelector,
 		},
 		&rbacv1.Role{}: {
-			Field: fields.SelectorFromSet(fields.Set{"metadata.name": common.WorkspaceRoleName()}),
+			Field: fields.SelectorFromSet(fields.Set{"metadata.name": common.OldWorkspaceRoleName()}),
 		},
 		&rbacv1.RoleBinding{}: {
-			Field: fields.SelectorFromSet(fields.Set{"metadata.name": common.WorkspaceRolebindingName()}),
+			Field: fields.SelectorFromSet(fields.Set{"metadata.name": common.OldWorkspaceRolebindingName()}),
 		},
 	}
 

pkg/common/naming.go

@@ -119,21 +119,21 @@ func MetadataConfigMapName(workspaceId string) string {
 // can potentially push the name over the 63 character limit (if the original
 // object has a long name)
 func AutoMountConfigMapVolumeName(volumeName string) string {
-	return fmt.Sprintf("%s", volumeName)
+	return volumeName
 }
 
 func AutoMountSecretVolumeName(volumeName string) string {
-	return fmt.Sprintf("%s", volumeName)
+	return volumeName
 }
 
 func AutoMountPVCVolumeName(pvcName string) string {
-	return fmt.Sprintf("%s", pvcName)
+	return pvcName
 }
 
-func WorkspaceRoleName() string {
+func OldWorkspaceRoleName() string {
 	return "workspace"
 }
 
-func WorkspaceRolebindingName() string {
+func OldWorkspaceRolebindingName() string {
 	return constants.ServiceAccount + "dw"
 }

pkg/provision/workspace/rbac.go

@@ -51,7 +51,7 @@ func generateRBAC(namespace string) []client.Object {
 	return []client.Object{
 		&rbacv1.Role{
 			ObjectMeta: metav1.ObjectMeta{
-				Name:      common.WorkspaceRoleName(),
+				Name:      common.OldWorkspaceRoleName(),
 				Namespace: namespace,
 			},
 			Rules: []rbacv1.PolicyRule{
@@ -106,7 +106,7 @@ func generateRBAC(namespace string) []client.Object {
 		},
 		&rbacv1.RoleBinding{
 			ObjectMeta: metav1.ObjectMeta{
-				Name:      common.WorkspaceRolebindingName(),
+				Name:      common.OldWorkspaceRolebindingName(),
 				Namespace: namespace,
 			},
 			RoleRef: rbacv1.RoleRef{