Update samples

[amisevsk]

What does this PR do?

• Use https://eclipse-che.github.io/che-plugin-registry/ for plugin devfiles instead of https://che-plugin-registry-main.surge.sh
• Use che-code as editor plugin for all samples except explicit Theia sample
• Fix issues with commands (wrong path -- use $PROJECT_SOURCE instead of $PROJECTS_ROOT)
• Add dev containers to main samples (code-latest.yaml and theia-latest.yaml) so that container contributions are used (editor should merge component into dev component)
• Use contributions for all plugins (rather than plugin components)

What issues does this PR fix or reference?

N/A

Is it tested? How?

Test that samples generally work as expected. If testing on minikube, it may be necessary to pre-pull images, as the UDI image is very large (3.7GB):

minikube ssh docker pull quay.io/devfile/universal-developer-image:latest
# Or, depending on the sample used
minikube ssh docker pull quay.io/devfile/universal-developer-image@sha256:d1709bbdfa076474f58f796026a2ed2dd3b24fea7e51ce2cc984e729663ff62c

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[codecov]

Codecov Report

Base: 50.27% // Head: 50.27% // No change to project coverage 👍

Coverage data is based on head (5bef0c8) compared to base (6088128).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   50.27%   50.27%           
=======================================
  Files          70       70           
  Lines        6021     6021           
=======================================
  Hits         3027     3027           
  Misses       2765     2765           
  Partials      229      229           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[AObuchow]

Tested on OpenShift 4.12.

• pod-overrides sample failed since the kata RuntimeClass was not found (to be expected)
• theia-latest sample works as expected
• Unfortunately, for all the samples using Che Code, I got the following error about the application not being served at the endpoint:

[amisevsk]

Unfortunately, for all the samples using Che Code, I got the following error about the application not being served at the endpoint

Hm, I'll have to take a look

[l0rd]

I have tested on a fresh OCP 4.12 cluster (I have installed DWO with make install) and k apply -f code-latest.yaml failed with "Init Container project-clone has state CrashLoopBackOff" and from the logs:

2023/01/31 11:44:54 Failed to get temporary directory for setting up projects: mkdir /projects/project-clone-1091890368: permission denied

[l0rd]

Otherwise I have the same result as @AObuchow but removing path: '?tkn=eclipse-che' in vscode definition (or opening the main URL without ?tkn=eclipse-che) fixes the problem. But that's not related to this PR so I have opened a separate one.

[nickboldt]

related to eclipse-che/che#21973

Note that the ?tkn=eclipse-che fix has also been done downstream for 3.5/3.x: redhat-developer/devspaces#880

[AObuchow]

Note that the ?tkn=eclipse-che fix has also been done downstream for 3.5/3.x: redhat-developer/devspaces#880

Will do a re-test, thanks Nick 👍 😎

[AObuchow]

I've opened the following 2 issues which are related to this PR. They could be solved in separate commits in this PR, or as separate PRs:

#1028
#1027

[AObuchow]

I seem to be encountering some CheCode (?) bugs:

When trying out the git-clone sample, code latest and the ephemeral storage sample, I got the following errors on Firefox specifically:

Refresh the page would cause either of these errors would pop up.

On the per-workspace sample, the editor initially started up, but clicking on the web-nodejs-sample project in the file explorer (which was written in yellow text) gave the following error:

This issue occured on Chrome less often, but still happened sometimes (The workbench failed to connect to the server (Error: WebSocket close with status code 10006)).

Another oddity: Though the git-clone sample workspace opened in Chrome, there's no devworkspace-operator project in the file explorer? And the devfile in the workspace is incorrect?

exec'ing into the workspace pod (or opening up a terminal in the editor) showed that the devworkspace-operator project was there. I thought at first this issue occured cause I had multiple workspaces started at the same time, but this still happened after deleting all workspaces and starting the git-clone sample again.

I'm assuming these are all Che Code bugs but not sure yet. Will file a bug report about these issues.
Even then, it might be best for these issues to be resolved before we merge this PR so that the samples all work as expected.

[amisevsk]

Retested samples on OpenShift 4.12, using Chromium 109.0.5414.74 and Firefox 109.0:

• Che-code samples start now, after Mario's fix. This led me to discover a bug in DWO's 'basic' routing reconciler: DevWorkspaceRouting reconciler breaks endpoints when they specify a path #1031. I'll fix this one asap.
• I cannot reproduce issues around lost connection, etc., and workspaces work as expected (to my experience). I'm able to open a terminal session, files, etc.
• The issue for the git clone sample is expected behavior; when Code launches in the workspace, it opens the first project rather than the projects folder. You can open a workspace with all your projects manually.
  • This shouldn't be a problem, as devfiles are currently intended to only have one project

[amisevsk]

@AObuchow This PR is still waiting on approve/request changes

[AObuchow]

@AObuchow This PR is still waiting on approve/request changes

Thanks for the ping @amisevsk, I lost track of this - will finalize my review tomorrow and so we can get this merged

[AObuchow]

Tried all the updated samples and everything works as expected 🙏

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, AObuchow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amisevsk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment