Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: turn healthCheckHttpClient timeout from 500ms to 3s #1321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

feat: turn healthCheckHttpClient timeout from 500ms to 3s #1321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/workspace/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func setupHttpClients(k8s client.Client, logger logr.Logger) {
}
healthCheckHttpClient = &http.Client{
Transport: healthCheckTransport,
Timeout: 500 * time.Millisecond,
Timeout: 3 * 500 * time.Millisecond,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would actually be 1500 ms (1.5s) instead of 3s.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a doubt a checkout of a stash to high, the test that I deployed was set to a hard coded 3s

}
InjectCertificates(k8s, logger)
}
Expand Down
Loading