Add support for ephemeral storageClass
#493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
changed the title
ephemeral storageClass
sleshchenko
approved these changes
Jul 15, 2021
| "github.com/devfile/devworkspace-operator/pkg/library/container" | ||
| ) | ||
|
|
||
| // The CommonStorageProvisioner provisions one PVC per namespace and configures all volumes in a workspace |
There was a problem hiding this comment.
Woops :D
My copy-paste is discovered
JPinkney
approved these changes
Jul 15, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add new storageclass 'ephemeral' to support creating workspaces where all volumes are emptyDir. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
ephemeral-storageclass
branch
from
9f80c7c
to
dc70ba8
Compare
|
New changes are detected. LGTM label has been removed. |
|
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path |
|
/test v7-devworkspace-happy-path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for the
ephemeralstorageClass (use emptyDir for all DevWorkspace volumes). This is useful (at least) for testing non-storage related usecases of DWO, as it avoids the need for a cleanup pod on every DevWorkspace.Currently, the implementation is very simple and does no validation (e.g. that all container components reference existing volumes).
What issues does this PR fix or reference?
No issue created AFAIK but was very useful while testing #492
Is it tested? How?
Set
.spec.template.attributes.controller.devfile.io/storage-type: "ephemeral"and start workspace.PR Checklist
/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-pathto trigger)v7-devworkspaces-operator-e2e: DevWorkspace e2e testv7-devworkspace-happy-path: DevWorkspace e2e test