Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update devfile API dependency to current main branch #797

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

amisevsk
Copy link
Collaborator

@amisevsk amisevsk commented Mar 17, 2022

What does this PR do?

A full diff between the previous and current devfile API dependencies is here.

What issues does this PR fix or reference?

Required for eclipse-che/che#17894

Is it tested? How?

  • Test setting .spec.template.components[].container.annotations.deployment in a DevWorkspace and check that annotations are propagated to the workspace Deployment
  • DWO should be upgradeable in OLM to the new version with updated CRDs.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Relevant devfile/api changes:
* introduce autoBuild field on image components
* introduce deployByDefault field on OpenShift and Kubernetes components
* introduce annotations field on various objects to specify annotations
  for the kubernetes object to be created
* add version for import references

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Adapt handling of additional annotations on the workspace Deployment to
match what is expected from the devfile API (Annotations field on
container components).

As part of supporting this, removes support for specifying additional
annotations/labels via attributes.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, ibuziuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amisevsk amisevsk merged commit 3f437aa into devfile:main Mar 21, 2022
@amisevsk amisevsk deleted the update-devfile-api-dep branch March 21, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants