Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for defining pod and container overrides via attribute #944

Merged
merged 8 commits into from
Oct 19, 2022
Merged

Add support for defining pod and container overrides via attribute #944

merged 8 commits into from
Oct 19, 2022

Commits on Oct 11, 2022

  1. Add 'pod-overrides' attribute to constants 

    Since we've decided not to add a field to the DevWorkspace API for
podSpecOverrides, instead use an attribute to support the same purpose.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b27b403 View commit details
    Browse the repository at this point in the history

  2. Add support for workspace pod overrides via attribute 

    Add support for overriding any field in the workspace's deployment
PodTemplateSpec via specifying an attribute. To make the attribute
easier to use, it can be defined multiple times in the DevWorkspace,
with each instance of the field being applied over the previous.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    bf57cf5 View commit details
    Browse the repository at this point in the history

  3. Add test cases to cover pod-overrides attribute 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    03b40e3 View commit details
    Browse the repository at this point in the history

  4. Add sample that uses pod overrides attribute 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    2ce8f54 View commit details
    Browse the repository at this point in the history

  5. Add 'container-overrides' attribute to constants 

    Add attribute 'container-overrides' that can be used to override fields
in containers used in a workspace.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    e5466e4 View commit details
    Browse the repository at this point in the history

  6. Add support for container-overrides defined on container components 

    Apply container-overrides as strategic merge patches on top of workspace
containers when defined.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b735b99 View commit details
    Browse the repository at this point in the history

  7. Add tests to cover container-overrides attribute 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    29a7c9c View commit details
    Browse the repository at this point in the history

  8. Add container overrides sample 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    8985cf0 View commit details
    Browse the repository at this point in the history