Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Authoring Documents #150

Merged
merged 6 commits into from
Apr 14, 2022
Merged

Update Authoring Documents #150

merged 6 commits into from
Apr 14, 2022

Conversation

maysunfaisal
Copy link
Member

Signed-off-by: Maysun J Faisal maysunaneek@gmail.com

Fixes devfile/api#809

@maysunfaisal
Add apply command authoring page
8d43490 
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

🎊 Navigate the preview: https://devfile-docs-150.surge.sh 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

maysunfaisal and others added 2 commits March 30, 2022 15:24
@maysunfaisal
Update to 2.2.0, add deploy kind, add event to nav
11f90ad 
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@yangcao77
update kubernetes component to include deployByDefault information, u…
f712426 
…pdate container component on sprcifying a volumeMount, update parent id reference with version specified

Signed-off-by: Stephanie <yangcao@redhat.com>
@maysunfaisal
Add image component authoring doc
e45111e 
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@maysunfaisal
Merge branch '809-1' of github.com:maysunfaisal/docs into 809-1
fc6f708
@maysunfaisal
Update caption for image component
ccab270 
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@maysunfaisal maysunfaisal changed the title [WIP] Update Authoring Documents Update Authoring Documents Apr 7, 2022
@maysunfaisal maysunfaisal requested a review from jc-berger April 7, 2022 15:01
jc-berger
jc-berger approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2022

@HarshCasper: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HarshCasper, jc-berger, maysunfaisal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal
Copy link
Member Author

The grammatical suggestions in the CI seem to be for docs whose content were not updated(just the devfile yaml was updated).

Merging as a result.

@maysunfaisal maysunfaisal merged commit de33e73 into devfile:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jc-berger jc-berger jc-berger approved these changes

@HarshCasper HarshCasper HarshCasper approved these changes

Assignees

@jc-berger jc-berger

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update 2.2.0 Author’s guide to include new feature introduced
4 participants
@maysunfaisal @HarshCasper @jc-berger @yangcao77