removed references to Che from devfile docs #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
reviewed
Dec 10, 2020
docs/modules/user-guide/partials/proc_adding-plugin-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_limiting-resources-usage.adoc
Outdated
Show resolved
Hide resolved
|
@sleshchenko, thanks for the review! I've addressed your comments and applied the feedback to all the docs. The new, squashed commit is up now. Thanks! |
elsony
requested changes
Dec 11, 2020
docs/modules/user-guide/partials/proc_adding-container-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_limiting-resources-usage.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_limiting-resources-usage.adoc
Outdated
Show resolved
Hide resolved
|
LGTM for the lang perspective. |
elsony
requested changes
Jan 7, 2021
docs/modules/user-guide/partials/proc_limiting-resources-usage.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_limiting-resources-usage.adoc
Outdated
Show resolved
Hide resolved
|
Thanks, @elsony, new, squashed commit is up! |
rkratky
requested changes
Jan 12, 2021
docs/modules/user-guide/partials/proc_adding-commands-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-name-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-name-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-name-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-name-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-commands-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-commands-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-container-component-to-a-devfile.adoc
Show resolved
Hide resolved
omitted eclipse references fixed typo and omitted unneeded lines added needed context ascii changes
jc-berger
changed the title
rkratky
approved these changes
Jan 21, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elsony, jc-berger, rkratky The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #76.
I simply removed references to Che in the devfile docs. If the content no longer makes sense without the Che reference, more revision will be necessary.