Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert workaround as odo install issue is fixed #57

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

josephca
Copy link
Collaborator

@josephca josephca commented Mar 9, 2022

Signed-off-by: Joseph Kim joskim@redhat.com

What does this PR do?

Revert the workaround to bypass the odo install issue as the issue is fixed.

What issues does this PR fix or reference?

devfile/api#793

Is your PR tested? Consider putting some instruction how to test your changes

Tested by PR tests

Signed-off-by: Joseph Kim <joskim@redhat.com>
@openshift-ci openshift-ci bot requested a review from elsony March 9, 2022 15:21
@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 9, 2022
@josephca josephca merged commit bd0a4d1 into devfile:main Mar 9, 2022
@josephca josephca deleted the revertWorkaround branch March 9, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant