backport proxy and custom timeout support to console v4.11 #148
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
| RegistryURLs: registryURLs, | ||
| DefaultNamespace: defaultNamespace, | ||
| Context: context, | ||
| K8sClient: client, |
There was a problem hiding this comment.
should include HTTPTimeout?
There was a problem hiding this comment.
actually, that's just an example usage HTTPTimeout is optional so we can leave it out
| @@ -81,6 +81,8 @@ type ParserArgs struct { | |||
| Context context.Context | |||
| // K8sClient is the Kubernetes client instance used for interacting with a cluster | |||
| K8sClient client.Client | |||
| // HTTPTimeout overrides the request and response timeout values for reading a parent devfile reference from the registry. If a negative value is specified, the default timeout will be used. | |||
| HTTPTimeout *int | |||
There was a problem hiding this comment.
any particular reason we make it a pointer?
There was a problem hiding this comment.
yes, it's to determine if this value is unset or not. If unset, we will use the default value of 30s
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Kim Tsao ktsao@redhat.com
What does this PR do?:
Backports the changes to a dependency release supported by console 4.11. Fix was verified in 4.12 by the console team
Which issue(s) this PR fixes:
devfile/api#926
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer: