Prepare for 0.3.0 release #92

thepetk · 2024-07-30T17:01:11Z

Please specify the area for this PR

/releng

What does does this PR do / why we need it:

This PR updates the bundle dir for the release of 0.3.0 version of the registry-operator

Which issue(s) this PR fixes:

Partially fixes devfile/api#1605

PR acceptance criteria:

Test Coverage
- Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
Gosec scans
- Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

Does the registry operator documentation need to be updated with your changes?

Testing changes

Running Unit Tests

Running Integration Tests

Special notes to the reviewer:

* Detect and use oc / kubectl for integration tests Signed-off-by: Philippe Martin <phmartin@redhat.com> * Use K8S_CLI first, then look in path instead of running version command Signed-off-by: Philippe Martin <phmartin@redhat.com> * Document Signed-off-by: Philippe Martin <phmartin@redhat.com> --------- Signed-off-by: Philippe Martin <phmartin@redhat.com>

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* release workflow Signed-off-by: Michael Valdron <mvaldron@redhat.com> * deploy minikube ci script Signed-off-by: Michael Valdron <mvaldron@redhat.com> * deploy operator job Signed-off-by: Michael Valdron <mvaldron@redhat.com> * set imagePullPolicy to 'Never' to use local built image Signed-off-by: Michael Valdron <mvaldron@redhat.com> * release deployment checks on kubernetes 1.25 & 1.26 Signed-off-by: Michael Valdron <mvaldron@redhat.com> * publishing operator bundle requires release deploy checks to pass Signed-off-by: Michael Valdron <mvaldron@redhat.com> * remove unnecessary ingress minikube addon Signed-off-by: Michael Valdron <mvaldron@redhat.com> * olm deploy check Signed-off-by: Michael Valdron <mvaldron@redhat.com> * version check Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix yq actions Signed-off-by: Michael Valdron <mvaldron@redhat.com> * download yq locally for version check Signed-off-by: Michael Valdron <mvaldron@redhat.com> * install operator-sdk Signed-off-by: Michael Valdron <mvaldron@redhat.com> * operator-sdk makefile variable Signed-off-by: Michael Valdron <mvaldron@redhat.com> * skip olm deploy check Signed-off-by: Michael Valdron <mvaldron@redhat.com> * setup go & operator-sdk for deploy checks Signed-off-by: Michael Valdron <mvaldron@redhat.com> * convert kubernetes deploy checks into kubernetes integration tests Signed-off-by: Michael Valdron <mvaldron@redhat.com> * release ci labelling fixups Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add additional time for registry operator to setup before running k8s integration testing Signed-off-by: Michael Valdron <mvaldron@redhat.com> * make k8s integration testing not required for release image pushing Signed-off-by: Michael Valdron <mvaldron@redhat.com> * pin actions to commit SHA Signed-off-by: Michael Valdron <mvaldron@redhat.com> * use go.mod version Co-authored-by: Armel Soro <armel@rm3l.org> Signed-off-by: Michael Valdron <mvaldron@redhat.com> * set up go after source checkout Signed-off-by: Michael Valdron <mvaldron@redhat.com> * use gh provided CI variable instead parameter Signed-off-by: Michael Valdron <mvaldron@redhat.com> * use strategy.matrix for k8s version for integration testing Signed-off-by: Michael Valdron <mvaldron@redhat.com> * quote CI variable Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Co-authored-by: Armel Soro <armel@rm3l.org>

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* release branching PR workflow Signed-off-by: Michael Valdron <mvaldron@redhat.com> * check version uses VERSION file as base, no longer takes ref_name as parameter Signed-off-by: Michael Valdron <mvaldron@redhat.com> * registry operator built image for release integration testing now uses VERSION file instead of ref_name Signed-off-by: Michael Valdron <mvaldron@redhat.com> * revert docker/build-push-action to v1.1.x Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* update typos in contributing.md Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * fix typo in readme Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

* update documentation for podman support Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update Makefile to add podman commands Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update readme wording for engine being used Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

…evfile#60) * patch dependencies Signed-off-by: Michael Valdron <mvaldron@redhat.com> * disable http/2 by default Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add instructions to enable http/2 Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

Needed for self servicing openshift ci changes

Update OWNERS

* add missing DCO file Signed-off-by: Michael Valdron <mvaldron@redhat.com> * contributing guide revisions Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

… images (devfile#68) * add target arch support to build container make rules Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update manager rule to build for other platforms Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update env variables table in README Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add 'Using other platforms' section to contributing guide Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix OpenShift CI: set default target arch build arg to 'amd64' Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* update readme to properly link to changelog Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add exemptions and best practice badge Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * remove artifact hub exemption Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

* add scorecard workflow and badge Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * remove irrelevant info Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

Signed-off-by: thepetk <thepetk@gmail.com>

This reverts commit 47dd095. Signed-off-by: thepetk <thepetk@gmail.com>

Signed-off-by: thepetk <thepetk@gmail.com>

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

* update devfile registry maintainers list Signed-off-by: Michael Valdron <mvaldron@redhat.com> * next version bump Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

Signed-off-by: thepetk <thepetk@gmail.com>

…e_field Implement DevfileRegistry CRD MemoryLimit field

* Add ingressClass field Signed-off-by: thepetk <thepetk@gmail.com> * Update description for ingressClass Signed-off-by: thepetk <thepetk@gmail.com> * Update defaults with k8s ingress class Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com>

* update ingress hostname Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update known issues Signed-off-by: Jordan Dubrick <dubrickjordan@gmail.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> Signed-off-by: Jordan Dubrick <dubrickjordan@gmail.com>

…direct dependencies (devfile#85) Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* add override fields to DevfileRegistry CRD Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add override getters and defaults Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

…ntime#2744 (devfile#87) Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* app name functions and refactored devfile registry labels function for app name getter changes Signed-off-by: Michael Valdron <mvaldron@redhat.com> * truncateName & LabelsForDevfileRegistry test cases Signed-off-by: Michael Valdron <mvaldron@redhat.com> * app name getter test cases Signed-off-by: Michael Valdron <mvaldron@redhat.com> * refactor naming.go functions to use fully qualified app name instead of CR name Signed-off-by: Michael Valdron <mvaldron@redhat.com> * change truncated length of app full name part of configmap name to add space for suffix part Signed-off-by: Michael Valdron <mvaldron@redhat.com> * naming function getter test cases Signed-off-by: Michael Valdron <mvaldron@redhat.com> * truncateName & truncateNameLengthN comment blocks Signed-off-by: Michael Valdron <mvaldron@redhat.com> * k8s ingress host name uses app full name rather than CR name to match OpenShift route url Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix full name contains case Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix given CR names in integration test cases to contain default app name devfile-registry Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* update documentation for testing the operator Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update pr template for testing changes Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * make reference to files consistent cases Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add comment as reminder to update docs Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * link test instructions in pr template to contributing Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

* add logic for handling missing ingress domain Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * use local hostname if ingress skipped Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update localhost values to use global var Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * fix typo for using localhost constant Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * remove protocol from local hostname constant Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * create helper func for skipping ingress Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * prefix http protocol to url Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add logic for skipping checks for missing ingress k8s cases Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * cherry pick remove items & block deployment if ingress unset Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

* add qemu to ci Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update documentation Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add environment variable for build only to ci Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * implement multi arch building and pushing Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update ci for buildx commands Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * separate podman buildx to have build and push commands Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * break buildx into build and push commands Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update workflows with new build and push commands Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update documentation with new commands Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

Signed-off-by: thepetk <thepetk@gmail.com>

Jdubrick

Do these changes go into main or a release branch? I just ask because the VERSION file is still at 0.1.4 and doesn't look like it has been being updated on main

thepetk · 2024-08-13T13:38:40Z

Do these changes go into main or a release branch? I just ask because the VERSION file is still at 0.1.4 and doesn't look like it has been being updated on main

As decided, in order to unblock a potential release automation we're going to:

Merge the current PR to release-v0.
Update the operatorhub & openshift-catalog sides.
Publish v0.3.0 and announce it.
Finally, we're going to merge the release-v0 branch into main making the v0.3.0 the latest release of the operator.

openshift-ci · 2024-08-13T13:45:05Z

@thepetk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.15-images	`f10aded`	link	true	`/test v4.15-images`
ci/prow/v4.15-registry-operator-integration-test	`f10aded`	link	true	`/test v4.15-registry-operator-integration-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci · 2024-08-13T13:50:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

thepetk · 2024-08-13T14:07:09Z

@Jdubrick @michael-valdron as the current PR had a few conflicts when tried to rebase it with main, I've closed it against #95 which tries to merge the v0.3.0 release updates directly to release-v0 branch.

feloy and others added 30 commits October 12, 2023 16:04

add license headers to scripts and configs (devfile#55)

3fedd3e

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

fixed source path for local build (devfile#58)

90f0e3d

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

Typo Fixes to README.md and CONTRIBUTING.md (devfile#59)

b4ddb0d

* update typos in contributing.md Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * fix typo in readme Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

fix missing icon and code block formatting (devfile#62)

45eb470

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

update owners (devfile#64)

0ab308d

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

Update OWNERS

4df72a7

Needed for self servicing openshift ci changes

Merge pull request devfile#65 from devfile/johnmcollier-patch-4

deec778

Update OWNERS

[Devtools Week] Update contributing guide (devfile#67)

cb5c55e

* add missing DCO file Signed-off-by: Michael Valdron <mvaldron@redhat.com> * contributing guide revisions Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

releases README section (devfile#70)

3c31f76

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

add scorecard workflow and badge (devfile#72)

f55ab8e

* add scorecard workflow and badge Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * remove irrelevant info Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

Define DevfileRegistrySpecContainer MemoryLimit field

5036482

Signed-off-by: thepetk <thepetk@gmail.com>

Update defaults with MemoryLimit field

466123f

Signed-off-by: thepetk <thepetk@gmail.com>

Update deployment with MemoryLimit field

5b8df20

Signed-off-by: thepetk <thepetk@gmail.com>

Update manifests

78ccb49

Signed-off-by: thepetk <thepetk@gmail.com>

Create new test cases

15b6e97

Signed-off-by: thepetk <thepetk@gmail.com>

Revert "Update manifests"

85920f8

This reverts commit 47dd095. Signed-off-by: thepetk <thepetk@gmail.com>

Update manifests

af35d66

Signed-off-by: thepetk <thepetk@gmail.com>

minikube and macos documentation (devfile#77)

4865ad6

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

Add getDevfileRegistrySpecContainer test cases

75879f8

Signed-off-by: thepetk <thepetk@gmail.com>

Revert updates to deployment.go

0642ab7

Signed-off-by: thepetk <thepetk@gmail.com>

Merge pull request devfile#76 from thepetk/ft/add_memorylimit_resourc…

a9f14a4

…e_field Implement DevfileRegistry CRD MemoryLimit field

Jdubrick and others added 8 commits March 6, 2024 11:50

bump github.com/devfile/registry-support/registry-library to patch in…

bc2d8f4

…direct dependencies (devfile#85) Signed-off-by: Michael Valdron <mvaldron@redhat.com>

Add override CRD fields (devfile#82)

7b69290

* add override fields to DevfileRegistry CRD Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add override getters and defaults Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com>

fix setup-envtest version to workaround kubernetes-sigs/controller-ru…

c385aba

…ntime#2744 (devfile#87) Signed-off-by: Michael Valdron <mvaldron@redhat.com>

openshift-ci bot added the do-not-merge/work-in-progress label Jul 30, 2024

openshift-ci bot requested review from elsony and Jdubrick July 30, 2024 17:01

openshift-ci bot added the approved label Jul 30, 2024

thepetk changed the title ~~WIP: Prepare for 0.30 release~~ WIP: Prepare for 0.3.0 release Jul 30, 2024

Prepare for 0.30 release

f10aded

Signed-off-by: thepetk <thepetk@gmail.com>

thepetk force-pushed the ft/prepare_new_release branch from 528d36e to f10aded Compare July 30, 2024 17:02

Jdubrick reviewed Jul 31, 2024

View reviewed changes

thepetk changed the base branch from main to release-v0 August 13, 2024 13:35

thepetk changed the title ~~WIP: Prepare for 0.3.0 release~~ Prepare for 0.3.0 release Aug 13, 2024

openshift-ci bot removed the do-not-merge/work-in-progress label Aug 13, 2024

thepetk requested a review from michael-valdron August 13, 2024 13:36

Merge branch 'release-v0' into ft/prepare_new_release

67d6574

thepetk closed this Aug 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare for 0.3.0 release #92

Prepare for 0.3.0 release #92

thepetk commented Jul 30, 2024

Jdubrick left a comment

thepetk commented Aug 13, 2024

openshift-ci bot commented Aug 13, 2024

openshift-ci bot commented Aug 13, 2024

thepetk commented Aug 13, 2024

Prepare for 0.3.0 release #92

Prepare for 0.3.0 release #92

Conversation

thepetk commented Jul 30, 2024

Jdubrick left a comment

Choose a reason for hiding this comment

thepetk commented Aug 13, 2024

openshift-ci bot commented Aug 13, 2024

openshift-ci bot commented Aug 13, 2024

thepetk commented Aug 13, 2024