Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport proxy support to console 4.10 #139

Merged

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Sep 19, 2022

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR

What does does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #?
devfile/api#926 and devfile/api#897
htps://github.com/devfile/api/issues/934

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
      We are relying on the console team to test
      Documentation (WIP)
  • Does the REST API doc need to be updated with your changes?
  • Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested a review from elsony September 19, 2022 17:00
@kim-tsao kim-tsao requested review from johnmcollier and removed request for elsony September 19, 2022 17:00
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@kim-tsao kim-tsao merged commit 3f85c85 into devfile:console-4.10-release Sep 19, 2022
@kim-tsao kim-tsao changed the title backport proxy support. Includes fixes for both devfile/api#926 and … backport proxy support to console 4.10 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants