Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools week: Set a specific image tag on Python stacks #166

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Mar 15, 2023

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?
Updated python and django stack and set up a specific tag (ubi/python:1-108) instead of "latest".

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk thepetk requested a review from elsony March 15, 2023 17:46
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thepetk
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk
Copy link
Contributor Author

thepetk commented Mar 20, 2023

Related issue: devfile/api#849

Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk thepetk self-assigned this Mar 22, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Mar 23, 2023

Separate issue for the bump up of golang version: devfile/api#1072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants