Fix tags for Java stack images #183
Conversation
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
There was a problem hiding this comment.
Note, inside the issue we have pointed out the
vert.ximage that needs update. I see that is using the next tag. IDK if this has to be updated to.
Based on devfile/api#849 (comment) and the age of the image tag compared to this comment I would say yes. I might bring up a topic of discussion as to why this image being used is very old and if there is a reason for it.
Use to latest fixed version for now, 7.37.2 looks like.
|
Thanks @michael-valdron :) A question that I have regarding the changes we make is if we should define a process (if we haven't yet) of monitoring to our stack images tags, in order to ensure that they are always updated. |
Signed-off-by: thepetk <thepetk@gmail.com>
|
Most probably the tests are failing because of devfile/api#1115 |
|
/retest |
There was a problem hiding this comment.
/lgtm
Validate stacks are be failing due to: devfile/api#1115
Will approve once this issue is resolved.
|
/retest |
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
It specifies the tags for 3 different stacks:
java-maven(fromregistry.access.redhat.com/ubi8/openjdk-11:latesttoregistry.access.redhat.com/ubi8/openjdk-11:1.15)java-quarkus(fromregistry.access.redhat.com/ubi8/openjdk-17:latesttoregistry.access.redhat.com/ubi8/openjdk-17:1.15)java-springboot(fromregistry.access.redhat.com/ubi8/openjdk-11:latesttoregistry.access.redhat.com/ubi8/openjdk-11:1.15)Which issue(s) this PR fixes:
Fixes devfile/api#849
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
I've tested all updates locally with
odo initandodo devin order to ensure that they are running correctly with the specified tag.