Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add alternative names #1165

Closed
1 task done
Snailedlt opened this issue Apr 28, 2022 · 5 comments
Closed
1 task done

[FEATURE REQUEST] Add alternative names #1165

Snailedlt opened this issue Apr 28, 2022 · 5 comments
Assignees
Labels
enhancement in-develop The fix/feature is present in `develop` branch but not merged into `master` yet

Comments

@Snailedlt
Copy link
Collaborator

I have searched through the issues and didn't find my problem.

  • Confirm

Problem

It would be much easier to find icons, if you could search for alternative names.

Take vscode for example.
Currently if I search for Visual Studio Code, or visualstudiocode nothing shows up. This is because the name of the icon is vscode.

The same is true for a lot of javascript frameworks and libraries, where they won't show up if you add js at the end

Possible Solution

If an array of altNames was added to the devicon.json file, it could be added as a search field, and let us search through that list as well.

Additional information

No response

Snailedlt added a commit to Snailedlt/devicon that referenced this issue Apr 28, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Apr 28, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Apr 28, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Apr 28, 2022
@Snailedlt Snailedlt mentioned this issue Apr 28, 2022
1 task
@Snailedlt
Copy link
Collaborator Author

@Thomas-Boi I think this is a duplicate of #327

@amacado
Copy link
Member

amacado commented Apr 30, 2022

@Snailedlt thanks for picking this issue up. If I got your idea right, #327 is a little different than your request. While #327 is about alias (which can be used in the font as css class) you are talking only about a search option on our website, right? For this purpose we might could use the already existing "tags" property in devicon.json. It's used like a keyword.. Does this satisfy your requirements?

https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60

// list of tags relating to the technology for search purpose (TBD)
"tags": string[], 

Currently the tags are not used but the website template could be adjusted to make use of it. What do you think?

@Snailedlt
Copy link
Collaborator Author

Snailedlt commented May 1, 2022

@amacado
Yes, that is correct, I'm only talking about search. I don't think tags should be mixed with altnames, since tags are used more as categories, while altnames are just alternative names for the icon.

It would be nice to be able to search for tags. Though it would make it harder to search if we just added it normally, since there would be a lot more search results for some searches.

I think a better way to add it would be to add a "tag" filter. So you could filter by tags, and then search for the name/altname. If we do it this way, it would be nice to also add a list of "allowed" tags, so that we don't get a lot of similar tags like "javascript", "js", "jsframework", etc...

What do you think?

@Thomas-Boi
Copy link
Member

I agree with @Snailedlt's point. I believe that the tags were always meant as extra filters, not things that you search for. I think the associated PR is a good idea. Changing the website so it searches the altnames should not be too hard either.

As long as @amacado and @Panquesito7 are down, I'm cool with this. I can even help with making a PR to search for the altnames too since it should be simple.

@Snailedlt
Copy link
Collaborator Author

Snailedlt commented May 3, 2022

@Thomas-Boi Thanks for that :)
The PR I have out now actually implements search already, so no need to add that :)

If this PR gets merged, you'll be able to search for altnames aswell as the normal names.

But let's wait and see what panquesito and amcado think then :)

Snailedlt added a commit to Snailedlt/devicon that referenced this issue Jun 3, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Jun 3, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Jun 3, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Jun 3, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Jun 3, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Jun 3, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Jun 3, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Jun 3, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Jun 3, 2022
amacado pushed a commit that referenced this issue Jun 6, 2022
* add altnames #1165

* fixup! add altnames #1165

* fixup! add altnames #1165

* fixup! add altnames #1165

* fixup! add altnames #1165

* fixup! add altnames #1165
@amacado amacado added the in-develop The fix/feature is present in `develop` branch but not merged into `master` yet label Jun 6, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165
@github-actions github-actions bot closed this as completed Feb 2, 2023
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this issue Dec 20, 2024
* add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165

* fixup! add altnames devicons#1165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement in-develop The fix/feature is present in `develop` branch but not merged into `master` yet
Projects
None yet
Development

No branches or pull requests

3 participants