Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Small fixes to the templates and wiki image #1005

Merged
merged 3 commits into from
Jan 10, 2022
Merged

New Feature: Small fixes to the templates and wiki image #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b88ba4b
Small fixes for the templates and forms
Thomas-Boi Jan 8, 2022
3492faf
Crop issue form image
Thomas-Boi Jan 8, 2022
b29a2aa
Make checkbox mandatory
Thomas-Boi Jan 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 37 additions & 26 deletions .github/ISSUE_TEMPLATE/bug_report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,37 @@
name: Bug Report
description: Report a bug/issue that you found in the SVGs, CSS files, etc.
title: '[BUG] <bug name>'
labels: [bug]
body:
- type: textarea
id: description
attributes:
label: Bug description
description: Short description of the bug that you found. Provide images/code if applicable.
validations:
required: true
- type: textarea
id: howtoreplicate
attributes:
label: Possible fixes or solutions
description: List any possible fixes/suggestions that you have in mind that could solve this issue.
validations:
required: true
- type: textarea
id: extrainformation
attributes:
label: Additional information
description: Is there anything else we should know about this bug?
validations:
required: false
name: Bug Report
description: Report a bug/issue that you found in the SVGs, CSS files, etc.
title: '[BUG] <bug name>'
labels: [bug]
body:
- type: markdown
attributes:
value: "## Before you continue, please search our open/closed issues to see if a similar issue has been addressed."

- type: checkboxes
attributes:
label: I have searched through the issues and didn't find my problem.
options:
- label: Confirm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: Confirm
- label: Confirm
validations:
required: true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pan, I'm not too sure what's the change here. Everything looks the same to me. Was it an end line or something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No 😅 This will make the checkbox obligatory to mark (see validations, required: true).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I was confused by the color coding. I tried to do that before too but GitHub doesn't support this attribute. I can however make that specific box mandatory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I was confused by the color coding. I tried to do that before too but GitHub doesn't support this attribute. I can however make that specific box mandatory.

Yes, that'd be great, thanks! 👍

required: true

- type: textarea
id: description
attributes:
label: Bug description
description: Short description of the bug that you found. Provide images/code if applicable.
validations:
required: true

- type: textarea
id: howtoreplicate
attributes:
label: Possible fixes or solutions
description: List any possible fixes/suggestions that you have in mind that could solve this issue.
validations:
required: true

- type: textarea
id: extrainformation
attributes:
label: Additional information
description: Is there anything else we should know about this bug?
61 changes: 35 additions & 26 deletions .github/ISSUE_TEMPLATE/feature_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,35 @@
name: Feature Request
description: Requesting a new feature or changes to an existing feature
title: '[FEATURE REQUEST] <feature name>'
labels: [enhancement]
body:
- type: textarea
id: currentproblem
attributes:
label: Problem
description: Tell us about the problem.
validations:
required: true
- type: textarea
id: possiblesolution
attributes:
label: Possible Solution
description: If you have an idea, please tell us what might solve the above problem.
validations:
required: true
- type: textarea
id: extrainformation
attributes:
label: Additional information
description: Is there anything else we should know about this feature request?
validations:
required: false
name: Feature Request
description: Requesting a new feature or changes to an existing feature
title: '[FEATURE REQUEST] <feature name>'
labels: [enhancement]
body:
- type: markdown
attributes:
value: "## Before you continue, please search our open/closed issues to see if a similar issue has been addressed."

- type: checkboxes
attributes:
label: I have searched through the issues and didn't find my problem.
options:
- label: Confirm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: Confirm
- label: Confirm
validations:
required: true

required: true

- type: textarea
id: currentproblem
attributes:
label: Problem
description: Tell us about the problem and its negative impacts.
validations:
required: true

- type: textarea
id: possiblesolution
attributes:
label: Possible Solution
description: If you have an idea, please tell us what might solve the above problem and the benefits it provides.

- type: textarea
id: extrainformation
attributes:
label: Additional information
description: Is there anything else we should know about this feature request?
63 changes: 37 additions & 26 deletions .github/ISSUE_TEMPLATE/icon_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,37 @@
name: Icon Request
description: Requesting a new icon or changes to an existing icon
title: '[ICON REQUEST]: <icon name>'
labels: ["request:icon"]
body:
- type: input
id: about
attributes:
label: About the icon
description: Short description of why you think this icon belongs in our project.
validations:
required: true
- type: textarea
id: links
attributes:
label: Links and sources
description: Provide links to the icon's official website/repository/anywhere that shows what the technology is about, and its official logo. If available, also provide some resources where the icon/SVG can be found (Font Awesome, Icomoon, etc.).
validations:
required: true
- type: textarea
id: extrainformation
attributes:
label: Additional information
description: Is there anything else we should know about this icon?
validations:
required: false
name: Icon Request
description: Requesting a new icon or changes to an existing icon
title: '[ICON REQUEST]: <icon name>'
labels: ["request:icon"]
body:
- type: markdown
attributes:
value: "## Before you continue, please search our open/closed issues to see if a similar issue has been addressed."

- type: checkboxes
attributes:
label: I have searched through the issues and didn't find my problem.
options:
- label: Confirm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: Confirm
- label: Confirm
validations:
required: true

required: true

- type: input
id: about
attributes:
label: About the icon
description: Short description of why you think this icon belongs in our project.
validations:
required: true

- type: textarea
id: links
attributes:
label: Links and sources
description: Provide links to the icon's official website/repository/anywhere that shows what the technology is about, and its official logo. If available, also provide some resources where the icon/SVG can be found (Font Awesome, Icomoon, etc.).
validations:
required: true

- type: textarea
id: extrainformation
attributes:
label: Additional information
description: Is there anything else we should know about this icon?
51 changes: 29 additions & 22 deletions .github/ISSUE_TEMPLATE/other.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,29 @@
name: Other
description: Use this for any other issues. Do not create blank issues
title: "[OTHER] <description>"
labels: ["awaiting triage"]
body:
- type: markdown
attributes:
value: "# Other issue"
- type: textarea
id: issuedescription
attributes:
label: What would you like to share?
description: Provide a clear and concise explanation of your issue.
validations:
required: true
- type: textarea
id: extrainfo
attributes:
label: Additional information
description: Is there anything else we should know about this issue?
validations:
required: false
name: Other
description: Use this for any other issues. Do not create blank issues
title: "[OTHER] <description>"
labels: ["awaiting triage"]
body:
- type: markdown
attributes:
value: "## Before you continue, please search our open/closed issues to see if a similar issue has been addressed."

- type: checkboxes
attributes:
label: I have searched through the issues and didn't find my problem.
options:
- label: Confirm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: Confirm
- label: Confirm
validations:
required: true

required: true

- type: textarea
id: issuedescription
attributes:
label: What would you like to share?
description: Provide a clear and concise explanation of your issue.
validations:
required: true

- type: textarea
id: extrainfo
attributes:
label: Additional information
description: Is there anything else we should know about this issue?
34 changes: 17 additions & 17 deletions .github/PULL_REQUEST_TEMPLATE/new_icon.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
## Double check these details before you open a PR

<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [] PR does not match another non-stale PR currently opened
- [] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
- [] PR's base is the `develop` branch.
- [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
- [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
- [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)

<!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->

**This PR closes NONE**
<!-- List issues that this PR would close above. Ex: This PR closes #1, #2, #3. -->

## Link to prove your SVG is correct and up-to-date.
<!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. -->
## Double check these details before you open a PR
<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [ ] PR does not match another non-stale PR currently opened
- [ ] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
- [ ] PR's base is the `develop` branch.
- [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
- [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
- [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)
<!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->
**This PR closes NONE**
<!-- List issues that this PR would close above. Ex: This PR closes #1, #2, #3. -->
## Link to prove your SVG is correct and up-to-date.
<!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. -->
Binary file modified docs/wiki/issue_form.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.