Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: emacs (original) #1096

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

jusuchin85
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #189

Link to prove your SVG is correct and up-to-date.

https://www.gnu.org/software/emacs/

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/emacs/emacs-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Thomas-Boi Thomas-Boi added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 24, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Thomas-Boi Thomas-Boi merged commit a674727 into devicons:develop Mar 24, 2022
@jusuchin85 jusuchin85 changed the title new icon: emacs (plain) new icon: emacs (original) Mar 24, 2022
@jusuchin85 jusuchin85 deleted the 189-emacs-icon branch March 24, 2022 10:00
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add emacs icon

* Fix typo: from plain to original
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add emacs icon

* Fix typo: from plain to original
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add emacs icon

* Fix typo: from plain to original
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants