Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: plotly (original, original-wordmark) #1134

Merged
merged 1 commit into from
May 7, 2022

Conversation

luizcarloscf
Copy link
Contributor

@luizcarloscf luizcarloscf commented Apr 9, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1131

Link to prove your SVG is correct and up-to-date.

https://plotly.com/

@amacado amacado added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection discussion Use this label for community discussions about changes/features/.. labels Apr 9, 2022
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! We appreciate every contribution. I'm not convinced yet, that plotly match our requirements. We'll discuss this in #1131.

@amacado amacado mentioned this pull request Apr 9, 2022
1 task
@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Apr 30, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels May 5, 2022
@amacado
Copy link
Member

amacado commented May 5, 2022

I'll re-run the bot. The icon looks suspicious in the "zoomed" screenshot (only a black square)

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@amacado
Copy link
Member

amacado commented May 5, 2022

I checked it: It's because of the color removal by icomoon. Not sure why the "listed" view works fine (even in black/white) but the zoomed version does not. I tried it by manually uploading the icon and got the same results. I'm not 100% sure how to proceed, should we merge it and see what the final icon font looks like?

Here's the downloadable result of the manual conversion which looks fine in the demo:
icomoon-plotly-v1.0.zip

@luizcarloscf
Copy link
Contributor Author

Is there something I could do in the svg icons?

@amacado
Copy link
Member

amacado commented May 7, 2022

@luizcarloscf can you download the file i provided and verify that the icon looks alright in the demo?

@luizcarloscf
Copy link
Contributor Author

I download the file and it looks ok. Here is a screenshot of the conversion:
print

@amacado amacado merged commit b0a3d71 into devicons:develop May 7, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@luizcarloscf luizcarloscf deleted the 1131-plotly-icons branch May 21, 2023 00:32
@weh weh mentioned this pull request Oct 17, 2023
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger discussion Use this label for community discussions about changes/features/.. feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants