Convert Style Elements to Attributes #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh my bad! I had missed that (and am still quite new at SVGs), sorry! I'm happy to redo them if you'd prefer. |
|
No problem
Thanks but there is no need for that, i have already cleaned up all icons in this PR |
amacado
approved these changes
Apr 30, 2022
1 task
Snailedlt
pushed a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* fix harvester icons * fix vsphere icons * fix k3os icons * fix rancher icons * fix k3os * fix rider icons * fix portainer icons * remove missing class attributes * add viewBox attribute
Snailedlt
pushed a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* fix harvester icons * fix vsphere icons * fix k3os icons * fix rancher icons * fix k3os * fix rider icons * fix portainer icons * remove missing class attributes * add viewBox attribute
Snailedlt
pushed a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* fix harvester icons * fix vsphere icons * fix k3os icons * fix rancher icons * fix k3os * fix rider icons * fix portainer icons * remove missing class attributes * add viewBox attribute
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of trying to release the newest version of the react devicons, I got an error caused by the usage of style elements. The standards state that those style elements shouldn't be used
so this pull request fixes all the icons which have style elements.
@thehedgefrog since all those icons were from you and I saw that you used Illustrator to create them, when you export the icon there is should be an option to include the css properties as
Presentation Attributes. In the future you should use that (Style Attributesshould also be fine).