Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: apachespark (original, original-wordmark, plain, plain-wordmark) #1186

Closed

Conversation

luizcarloscf
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #583

Link to prove your SVG is correct and up-to-date.

https://spark.apache.org/images/
https://spark.apache.org/

@luizcarloscf
Copy link
Contributor Author

I recreated the pull request with the correct title as suggested here #1184, but it seems to me that the regex expression here throw an error because of a typo...

pattern = re.compile(r"(?<=^new icon: )\w+ (?=\(.+\))|(?<=^update icon: )\w+ (?=\(.+\))", re.I)

Must the number of spaces between the icon name and the parentheses be exactly one?

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label May 15, 2022
@Panquesito7 Panquesito7 requested a review from amacado May 15, 2022 20:21
@amacado
Copy link
Member

amacado commented May 16, 2022

@luizcarloscf Yep, only one space after the icon name. I checked the regex using https://regexr.com/ and a double whitespace won't match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants