Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: streamlit (original, plain, original-wordmark, plain-wordmark) #1207

Merged
merged 2 commits into from
Jun 12, 2022
Merged

new icon: streamlit (original, plain, original-wordmark, plain-wordmark) #1207

merged 2 commits into from
Jun 12, 2022

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Jun 7, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1202

Link to prove your SVG is correct and up-to-date.

https://streamlit.io/brand

@Panquesito7 Panquesito7 added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Panquesito7 Panquesito7 requested a review from amacado June 8, 2022 17:50
Panquesito7
Panquesito7 previously approved these changes Jun 8, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! We just added a new property in devicon.json called altnames. Would you mind adding this (even empty) to your contribution?
https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60

@canaleal
Copy link
Member Author

Okay, sounds good. I'll add altnames.

@Panquesito7 Panquesito7 requested a review from amacado June 12, 2022 00:36
@amacado amacado merged commit de0218a into devicons:develop Jun 12, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…rk) (devicons#1207)

* new icon: streamlit (original, plain, original-wordmark, plain-wordmark)

* Added altnames to Streamlit in devicon.json file
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…rk) (devicons#1207)

* new icon: streamlit (original, plain, original-wordmark, plain-wordmark)

* Added altnames to Streamlit in devicon.json file
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…rk) (devicons#1207)

* new icon: streamlit (original, plain, original-wordmark, plain-wordmark)

* Added altnames to Streamlit in devicon.json file
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…rk) (devicons#1207)

* new icon: streamlit (original, plain, original-wordmark, plain-wordmark)

* Added altnames to Streamlit in devicon.json file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants