Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: envoy (original, original-wordmark, plain, plain-wordmark) #1228

Merged
merged 5 commits into from
Jul 29, 2022
Merged

new icon: envoy (original, original-wordmark, plain, plain-wordmark) #1228

merged 5 commits into from
Jul 29, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jun 23, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://www.envoyproxy.io/
https://www.envoyproxy.io/docs/envoy/latest/start/start

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 24, 2022
Panquesito7
Panquesito7 previously approved these changes Jun 24, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Could you please resolve the merge conflicts?
Let us know if you need any help with this! 🙂

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Inefficient

@Panquesito7 Panquesito7 dismissed their stale review June 24, 2022 02:57

Oops, I chose approve instead of request changes.

@kilianpaquier
Copy link
Contributor Author

Rebase done 🙂

@kilianpaquier kilianpaquier changed the title new icon: envoyproxy (original, original-wordmark) new icon: envoyproxy (original, original-wordmark, plain, plain-wordmark) Jun 27, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo the icon should be renamed to envoy, since the website and logo calls it that. Please tell me if I'm wrong though.

Other than that, there's just one comment on a tag.

PS: When renaming the icon, remember to rename the files, folders and PR title too

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt changed the title new icon: envoyproxy (original, original-wordmark, plain, plain-wordmark) new icon: envoy (original, original-wordmark, plain, plain-wordmark) Jul 28, 2022
@Snailedlt Snailedlt self-requested a review July 28, 2022 20:45
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 28, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt
Copy link
Collaborator

@Panquesito7 one of the checks is failing because the PR title was changed after the PR was made. I've re-ran the job, but it didn't work. Any ideas on how to fix it?
image

image

@kilianpaquier kilianpaquier marked this pull request as draft July 29, 2022 06:13
@kilianpaquier kilianpaquier marked this pull request as ready for review July 29, 2022 06:28
@kilianpaquier
Copy link
Contributor Author

@Panquesito7 one of the checks is failing because the PR title was changed after the PR was made. I've re-ran the job, but it didn't work. Any ideas on how to fix it? image

image

The first commit needed to be renamed too

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 29, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you. 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Efficient, Maintainable

@Panquesito7 Panquesito7 merged commit 160b7cd into devicons:develop Jul 29, 2022
@kilianpaquier kilianpaquier deleted the envoy branch August 18, 2022 17:27
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…evicons#1228)

* new icon: envoy (original, original-wordmark)

* renaming old commit

* removed bad object in devicon.json

* fix envoy after rebase
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…evicons#1228)

* new icon: envoy (original, original-wordmark)

* renaming old commit

* removed bad object in devicon.json

* fix envoy after rebase
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…evicons#1228)

* new icon: envoy (original, original-wordmark)

* renaming old commit

* removed bad object in devicon.json

* fix envoy after rebase
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants