Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) #1236

Merged
merged 11 commits into from
Aug 8, 2022
Merged

new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) #1236

merged 11 commits into from
Aug 8, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jun 27, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://www.karatelabs.io/

@kilianpaquier kilianpaquier changed the title new icon: karate (original, original-wordmark, plain, plain-wordmark) new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) Jun 27, 2022
@github-actions

This comment was marked as outdated.

@kilianpaquier kilianpaquier marked this pull request as ready for review June 28, 2022 20:38
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 28, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this: should we remove the plain and plain-wordmark and use original and original-wordmark as the font versions? After all, they're just one solid color.

Thanks.

__
sema-logo  Summary: ❓ I have a question

@kilianpaquier
Copy link
Contributor Author

What do you think about this: should we remove the plain and plain-wordmark and use original and original-wordmark as the font versions? After all, they're just one solid color.

Thanks.

__

sema-logo  Summary: ❓ I have a question

Yep 👍

@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Panquesito7
Copy link
Member

What do you think about this: should we remove the plain and plain-wordmark and use original and original-wordmark as the font versions? After all, they're just one solid color.
Thanks.
__
sema-logo

    [
      
        ![sema-logo](https://camo.githubusercontent.com/843687ee2a84b8cc104a1e4297c26c9db3d3f710080228887db6338b4550a240/68747470733a2f2f6170702e73656d61736f6674776172652e636f6d2f696d672f73656d612d747261792d6c6f676f2e676966)
      
    ](https://semasoftware.com/gh)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://semasoftware.com/gh)
    
    **Summary:** ❓ I have a question

Yep 👍

Cool, thanks! Let us know if you need any help. :)

@Snailedlt
Copy link
Collaborator

@Panquesito7 did the logos change? Original and Original wordmark have two colors (black and white), so they wouldn't work as fonts right?

Snailedlt
Snailedlt previously approved these changes Aug 6, 2022
@Snailedlt
Copy link
Collaborator

Snailedlt commented Aug 6, 2022

Imo it looks good as it is. Plain has a transparent instead of white person in the center. Seems fine to me :)

@kilianpaquier kilianpaquier changed the title new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) new icon: karatelabs (original, original-wordmark) Aug 6, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the karatelabs original icons don't look like the original logos on their website. They should be black and white, not just black

@kilianpaquier
Copy link
Contributor Author

Now the karatelabs original icons don't look like the original logos on their website. They should be black and white, not just black

Reverted the commit

@Snailedlt
Copy link
Collaborator

Nice, thanks :)
Now the question is, should the plain icons be white or black?

@kilianpaquier
Copy link
Contributor Author

Nice, thanks :) Now the question is, should the plain icons be white or black?

Black obviously

@Snailedlt Snailedlt removed the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 6, 2022
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! ✔️

@Snailedlt Snailedlt requested a review from Panquesito7 August 6, 2022 12:14
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Maintainable

@Panquesito7 Panquesito7 changed the title new icon: karatelabs (original, original-wordmark) new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) Aug 8, 2022
@Panquesito7 Panquesito7 merged commit e9bd76e into devicons:develop Aug 8, 2022
@kilianpaquier kilianpaquier deleted the karate branch August 18, 2022 17:28
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…ark) (devicons#1236)

* new icon: karatelabs (original, original-wordmark, plain, plain-wordmark)

* karatelabs| renamed karate to karatelabs

* karatelabs| renamed svg names

* karate| fix plain icon transparency

* karatelabs| removed original and renamed plain to original

* Revert "karatelabs| removed original and renamed plain to original"

This reverts commit caa9f92.

* karatelabs| changed plain icon colors
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…ark) (devicons#1236)

* new icon: karatelabs (original, original-wordmark, plain, plain-wordmark)

* karatelabs| renamed karate to karatelabs

* karatelabs| renamed svg names

* karate| fix plain icon transparency

* karatelabs| removed original and renamed plain to original

* Revert "karatelabs| removed original and renamed plain to original"

This reverts commit caa9f92.

* karatelabs| changed plain icon colors
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…ark) (devicons#1236)

* new icon: karatelabs (original, original-wordmark, plain, plain-wordmark)

* karatelabs| renamed karate to karatelabs

* karatelabs| renamed svg names

* karate| fix plain icon transparency

* karatelabs| removed original and renamed plain to original

* Revert "karatelabs| removed original and renamed plain to original"

This reverts commit caa9f92.

* karatelabs| changed plain icon colors
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…ark) (devicons#1236)

* new icon: karatelabs (original, original-wordmark, plain, plain-wordmark)

* karatelabs| renamed karate to karatelabs

* karatelabs| renamed svg names

* karate| fix plain icon transparency

* karatelabs| removed original and renamed plain to original

* Revert "karatelabs| removed original and renamed plain to original"

This reverts commit caa9f92.

* karatelabs| changed plain icon colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants