-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) #1236
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
@Panquesito7 did the logos change? Original and Original wordmark have two colors (black and white), so they wouldn't work as fonts right? |
Imo it looks good as it is. Plain has a transparent instead of white person in the center. Seems fine to me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the karatelabs original icons don't look like the original logos on their website. They should be black and white, not just black
This reverts commit caa9f92.
Reverted the commit |
Nice, thanks :) |
Black obviously |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ark) (devicons#1236) * new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) * karatelabs| renamed karate to karatelabs * karatelabs| renamed svg names * karate| fix plain icon transparency * karatelabs| removed original and renamed plain to original * Revert "karatelabs| removed original and renamed plain to original" This reverts commit caa9f92. * karatelabs| changed plain icon colors
…ark) (devicons#1236) * new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) * karatelabs| renamed karate to karatelabs * karatelabs| renamed svg names * karate| fix plain icon transparency * karatelabs| removed original and renamed plain to original * Revert "karatelabs| removed original and renamed plain to original" This reverts commit caa9f92. * karatelabs| changed plain icon colors
…ark) (devicons#1236) * new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) * karatelabs| renamed karate to karatelabs * karatelabs| renamed svg names * karate| fix plain icon transparency * karatelabs| removed original and renamed plain to original * Revert "karatelabs| removed original and renamed plain to original" This reverts commit caa9f92. * karatelabs| changed plain icon colors
…ark) (devicons#1236) * new icon: karatelabs (original, original-wordmark, plain, plain-wordmark) * karatelabs| renamed karate to karatelabs * karatelabs| renamed svg names * karate| fix plain icon transparency * karatelabs| removed original and renamed plain to original * Revert "karatelabs| removed original and renamed plain to original" This reverts commit caa9f92. * karatelabs| changed plain icon colors
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.
https://www.karatelabs.io/