-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: unifiedmodelinglanguage (original, original-wordmark, plain, plain-wordmark) #1241
Conversation
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sorry about all the confusion. I guess I was a little blind when I last checked the colors here 😅 |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patience and the contribution! 🙇 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…, plain-wordmark) (devicons#1241) * new icon: unifiedmodelinglanguage (original, original-wordmark, plain, plain-wordmark) - contributes devicons#104 * uml| fix tag language * uml| renamed svg and folder to full name * Apply suggestions from code review Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
…, plain-wordmark) (devicons#1241) * new icon: unifiedmodelinglanguage (original, original-wordmark, plain, plain-wordmark) - contributes devicons#104 * uml| fix tag language * uml| renamed svg and folder to full name * Apply suggestions from code review Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
…, plain-wordmark) (devicons#1241) * new icon: unifiedmodelinglanguage (original, original-wordmark, plain, plain-wordmark) - contributes devicons#104 * uml| fix tag language * uml| renamed svg and folder to full name * Apply suggestions from code review Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Consider simplifying it somewhat. The symbol about the trademark being registered (R) and (TM) isn't really necessary. Devicon also has no other icons with those symbols as far as I'm aware. People can search for the trademark registration when they need to know that information. The rest is fine in my opinion. |
@Lorenzo501 There's quite a few icons with trademark symbols now, though admittedly not that many on the master branch. I think leaving in the trademark symbol is fine, so long as the file doesn't get huge as a result of it ofc. |
When people use it and they make it a little bit smaller, then you won't even be able to read the trademark symbol. It'll just be a tiny circle which then looks out of place. It's essentially not even part of the logo, so at that point it'll just be rather inconvient for those who use a smaller size logo. And so in that case they will most likely fix it themselves by not using devicon for everything, which is a bit cumbersome, I'm sure you would agree. So I'd still suggest to remove it so that nobody will experience any issues using devicon for their website. You can see for yourself, if you decrease its size somewhat (the non-zoomed-in version), not even by a lot and I know for sure that a lot of people do this for their website, especially content for smartphones. Plus it looks a lot cleaner without it, in any case. Doing it for this one is a start. I don't know which other ones there are what you spoke about, but they can be improved too at some point. |
@Lorenzo501 I agree with you, I just cba to do it myself 😅 But if you want to fix it a PR would be highly appreciated :) |
…, plain-wordmark) (devicons#1241) * new icon: unifiedmodelinglanguage (original, original-wordmark, plain, plain-wordmark) - contributes devicons#104 * uml| fix tag language * uml| renamed svg and folder to full name * Apply suggestions from code review Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR contributes to #104
Link to prove your SVG is correct and up-to-date.
https://en.wikipedia.org/wiki/Unified_Modeling_Language