new icon: eclipse (original, original-wordmark, plain, plain-wordmark) #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snailedlt
requested changes
Jul 6, 2022
Hello @Snailedlt, An alias between which version and which other version ? Because I made SVG's for the plain and SVG's for the original. Maybe the line then ? |
|
Ahh, no I meant altname, not alias. Sorry my bad :) |
Co-authored-by: Snailedlt <snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
|
@Snailedlt Suggestions applied |
Snailedlt
previously approved these changes
Jul 7, 2022
|
@Panquesito7 Looks good to me |
Snailedlt
added a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
devicons#1258) * new icon: eclipse (original, original-wordmark, plain, plain-wordmark) - fix devicons#1215 * eclipse| applied suggestions on altnames and tags Co-authored-by: Snailedlt <snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt
added a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
devicons#1258) * new icon: eclipse (original, original-wordmark, plain, plain-wordmark) - fix devicons#1215 * eclipse| applied suggestions on altnames and tags Co-authored-by: Snailedlt <snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt
added a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
devicons#1258) * new icon: eclipse (original, original-wordmark, plain, plain-wordmark) - fix devicons#1215 * eclipse| applied suggestions on altnames and tags Co-authored-by: Snailedlt <snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt
added
the
feature:icon
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #1215
Link to prove your SVG is correct and up-to-date.
https://www.eclipse.org/ide/