Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: capacitor (original, original-wordmark, plain, plain-wordmark) #1274

Merged
merged 3 commits into from
Jul 23, 2022
Merged

new icon: capacitor (original, original-wordmark, plain, plain-wordmark) #1274

merged 3 commits into from
Jul 23, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jul 17, 2022 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #825

Link to prove your SVG is correct and up-to-date.

https://capacitorjs.com/

Snailedlt
Snailedlt requested changes Jul 23, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

altname and some tags suggested

devicon.json Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
kilianpaquier and others added 2 commits July 23, 2022 23:44
@kilianpaquier @Snailedlt
Update devicon.json
2961a4b 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@kilianpaquier @Snailedlt
Update devicon.json
cd90fca 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt
Snailedlt approved these changes Jul 23, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great as always!

LGTM ✔️
Thanks for contributing! 💯

@Snailedlt Snailedlt merged commit cf30c32 into devicons:develop Jul 23, 2022
@kilianpaquier kilianpaquier deleted the capacitor branch July 24, 2022 09:09
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: capacitor (original, original-wordmark, plain, plain-wordma…
6b69746 
…rk) (devicons#1274)

* new icon: capacitor (original, original-wordmark, plain, plain-wordmark) - fix devicons#825

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: capacitor (original, original-wordmark, plain, plain-wordma…
dea8810 
…rk) (devicons#1274)

* new icon: capacitor (original, original-wordmark, plain, plain-wordmark) - fix devicons#825

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: capacitor (original, original-wordmark, plain, plain-wordma…
8694c96 
…rk) (devicons#1274)

* new icon: capacitor (original, original-wordmark, plain, plain-wordmark) - fix devicons#825

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kilianpaquier @Snailedlt