-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: moleculer (original, plain) #1296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes. I also noticed that they have a few more logos, I'll make an issue so we can discuss further there
Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Done. I also updated all my PRs to replace the new object at the right place 🙂 |
Great, you are so damn fast, lol! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thanks for your contribution! 🚀
* new icon: moleculer (original, plain) * moleculer| review remarks Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Update devicon.json * moleculer| added wordmark icon * moved object in devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* new icon: moleculer (original, plain) * moleculer| review remarks Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Update devicon.json * moleculer| added wordmark icon * moved object in devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* new icon: moleculer (original, plain) * moleculer| review remarks Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * Update devicon.json * moleculer| added wordmark icon * moved object in devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1300
Link to prove your SVG is correct and up-to-date.
https://moleculer.services/