Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: ohmyzsh (original, plain) #1297

Merged
merged 2 commits into from
Jul 26, 2022
Merged

new icon: ohmyzsh (original, plain) #1297

merged 2 commits into from
Jul 26, 2022

Conversation

BenSouchet
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • [c] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1264

Link to prove your SVG is correct and up-to-date.

Based on the SVG file provided here by robbyrussell creator of Oh My Zsh.

@BenSouchet BenSouchet mentioned this pull request Jul 25, 2022
1 task
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, the rest looks excellent! 💯

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@BenSouchet
Copy link
Contributor Author

not looking to do more debates on that matter, I applied the modifications you wanted.

@Snailedlt
Copy link
Collaborator

@BenSouchet Thanks!
If you still don't agree with me, you should say so. I'm not always right, and as the author of the PR you should have a say too. I just wanted to voice my opinions.

I'll accept and keep the PR open for a bit in case you change your mind about anything

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️
Thanks for your contribution!
Clean and concise code, along with a great (custom?) plain icon 💯

@BenSouchet
Copy link
Contributor Author

LGTM ✔️ Thanks for your contribution! Clean and concise code, along with a great (custom?) plain icon 💯

The plain icon is an "edited" version where the white part is remove (boolean operation), this is the only way to have a valid glyph in the devicon font.

And for the altnames, we are two people with different opinions, I feel that the debate will go around in circles, so I'm okay with the modifications you wanted.

@Snailedlt
Copy link
Collaborator

The plain icon is an "edited" version where the white part is remove (boolean operation), this is the only way to have a valid glyph in the devicon font.

Nice! It looks nice too

@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 26, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt Snailedlt merged commit b9023a5 into devicons:develop Jul 26, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add OhMyZSH icon

* Change altnames for Oh My Zsh
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add OhMyZSH icon

* Change altnames for Oh My Zsh
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add OhMyZSH icon

* Change altnames for Oh My Zsh
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants