-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: cloudflare (plain, plain-wordmark, original, original-wordmark) #1298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but upon doing some research I found that their official logo kit is different from the one used here. We should probably change to that one, so we get the correct color palette, etc :)
Colors codes updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but still missing the white color though inside the logo itself, almost there
Edited + added the version with the white inside the cloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Perfect!
Clean and concise code, appropriate tags and altnames, and some nice custom plain icons specifically for devicons. Couldn't be better! 🥇
Thanks for another great contribution! 💯
Not sure why, but bot:peek isn't working for this PR :/ |
The PR title was not correct, I just updated it |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Oh, nice catch. Looks good now |
…ark) (devicons#1298) * Add cloudflare icon * Change Cloudflare color codes * Change icons for Cloudflare + add plain & plain-wordmark
…ark) (devicons#1298) * Add cloudflare icon * Change Cloudflare color codes * Change icons for Cloudflare + add plain & plain-wordmark
…ark) (devicons#1298) * Add cloudflare icon * Change Cloudflare color codes * Change icons for Cloudflare + add plain & plain-wordmark
…ark) (devicons#1298) * Add cloudflare icon * Change Cloudflare color codes * Change icons for Cloudflare + add plain & plain-wordmark
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR "PARTIALLY" closes #785
Link to prove your SVG is correct and up-to-date.
Taken from the official website https://www.cloudflare.com/and from the github repo https://github.com/cloudflare/research.cloudflare.com/blob/main/img/cloud.svgFrom https://www.cloudflare.com/logo/