-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: vala (original, plain, plain-wordmark) #1397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons you have look good, but can you also add one for vala-original-wordmark?
Should be same as vala-plain-wordmark, but with the same background as vala-original
@lunatic-fox So I guess option 3 (or maybe 2)? I'm not sure, but would also like more opinions on this. @BenSouchet @Panquesito7 what do you think of @lunatic-fox 's suggestions above, any preferences? |
Option 3 seems the best to me. It looks nice. |
Yes Option 2 or 3 is good and stick with the brand identity 👍 |
Well then, looks like you have your answer @lunatic-fox :) |
Yeah @Snailedlt. Option 3 wins. |
|
@lunatic-fox Approved, but you'll need to fix the conflict before merging, and I guess I'll have to approve again after that :) |
Solved it: I got a little bit concerned about this commit title: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! ✔️
Thank you for the contribution 🙇
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
* Add Vala * Add original-wordmark version
* Add Vala * Add original-wordmark version
* Add Vala * Add original-wordmark version
* Add Vala * Add original-wordmark version
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1360
Link to prove your SVG is correct and up-to-date.
https://vala.dev/
https://raw.githubusercontent.com/github/explore/f2320762bfd30d076b43d8c0d61be9fba3f85ca4/topics/vala/vala.png