Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: djangorest (original, plain, original-wordmark, plain-wordmark) #1407

Merged
merged 4 commits into from
Dec 10, 2022

Conversation

lunatic-fox
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1387

Link to prove your SVG is correct and up-to-date.

https://www.django-rest-framework.org/img/logo.png

@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 2, 2022
@github-actions

This comment was marked as outdated.

icons/djangorest/djangorest-original.svg Show resolved Hide resolved
devicon.json Show resolved Hide resolved
icons/djangorest/djangorest-plain.svg Show resolved Hide resolved
@Snailedlt Snailedlt requested review from a team, amacado and Panquesito7 and removed request for a team October 2, 2022 19:22
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022
Co-Authored-By: kilianpaquier <107955904+kilianpaquier@users.noreply.github.com>
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last suggestions hopefully

devicon.json Show resolved Hide resolved
devicon.json Show resolved Hide resolved
Snailedlt
Snailedlt previously approved these changes Nov 2, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Great work to everyone involved! 💯 It's not every day that we get to add all icon versions for a logo, let alone in the same PR!
Special thanks to @BenSouchet @lunatic-fox @kilianpaquier and @Panquesito7 for contributions both in the form of code, reviews and discussions!

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

devicon.json Show resolved Hide resolved
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved, hope it's good now :)

@Snailedlt Snailedlt requested review from kilianpaquier and BenSouchet and removed request for kilianpaquier and BenSouchet November 3, 2022 00:57
@Snailedlt Snailedlt merged commit 7ada3a4 into devicons:develop Dec 10, 2022
@lunatic-fox lunatic-fox deleted the add_djangorest branch June 1, 2023 12:29
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants