-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: llvm (original, plain) #1428
new icon: llvm (original, plain) #1428
Conversation
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat, but there's a few small issues with the original SVG (see comment below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better already!
Great work! 💯
Now there are only two very small things left:
- The black outlines look like they are slightly thicker than the ones on the original .png logo. The difference is so small so it's barely noticeable. Imo this doesn't need fixing, but it's there if you (or anyone else) wants to fix it.
- The colors are slightly different from what they should be, I made a suggestion with the correct color values. The diff doesn't look right in the GitHub UI, but if you diff it locally you'll see that only the color values changed :)
In summary:
Great work, almost there! Just implement the suggestion and everything else should be good enough to merge :)
Update colors Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greeat work @weh! ✔️ The icons look stunning! ✨
I'm interested in knowing what tool(s) you used to convert the PNG into SVG, would you be willing to share your knowledge? 🧠
Sure @Snailedlt Basically my Workflow is using the Tools mentioned on the Wiki Page https://github.com/devicons/devicon/wiki/Recommended-resources-and-tools
You may need to test the results with Trace Bitmap and tweak the params. In this Case the tricky part was the White Background. It got removed, in every variant. So i Gimp to create a "white only" version of the Image and combined both Inkscape converted Images in my IDE (or any text Editor you want). Inkscape writes pretty good editable svg xml files. Many times i do tweak colors and similar things in the text editor. |
@weh neat! Would be nice to have that step by step guide in the wiki somewhere. Maybe a separate section for Would you want to add that yourself, or should I do it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
* new icon: llvm (original, plain) * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * change color Co-authored-by: David Leal <halfpacho@gmail.com> * Add more tags Co-authored-by: David Leal <halfpacho@gmail.com> * Better svg version * Switch colors * Update icons/llvm/llvm-original.svg Update colors Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* new icon: llvm (original, plain) * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * change color Co-authored-by: David Leal <halfpacho@gmail.com> * Add more tags Co-authored-by: David Leal <halfpacho@gmail.com> * Better svg version * Switch colors * Update icons/llvm/llvm-original.svg Update colors Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* new icon: llvm (original, plain) * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * change color Co-authored-by: David Leal <halfpacho@gmail.com> * Add more tags Co-authored-by: David Leal <halfpacho@gmail.com> * Better svg version * Switch colors * Update icons/llvm/llvm-original.svg Update colors Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* new icon: llvm (original, plain) * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * change color Co-authored-by: David Leal <halfpacho@gmail.com> * Add more tags Co-authored-by: David Leal <halfpacho@gmail.com> * Better svg version * Switch colors * Update icons/llvm/llvm-original.svg Update colors Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
closes #688
Link to prove your SVG is correct and up-to-date.
https://llvm.org/Logo.html