Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: llvm (original, plain) #1428

Merged
merged 7 commits into from
Oct 11, 2022

Conversation

weh
Copy link
Contributor

@weh weh commented Oct 4, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

closes #688

Link to prove your SVG is correct and up-to-date.

https://llvm.org/Logo.html

@Snailedlt Snailedlt self-requested a review October 4, 2022 13:15
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 4, 2022
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
weh and others added 3 commits October 6, 2022 09:34
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat, but there's a few small issues with the original SVG (see comment below)

icons/llvm/llvm-original.svg Outdated Show resolved Hide resolved
@weh
Copy link
Contributor Author

weh commented Oct 7, 2022

i think this version is better now

image

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better already!
Great work! 💯

Now there are only two very small things left:

  1. The black outlines look like they are slightly thicker than the ones on the original .png logo. The difference is so small so it's barely noticeable. Imo this doesn't need fixing, but it's there if you (or anyone else) wants to fix it.
  2. The colors are slightly different from what they should be, I made a suggestion with the correct color values. The diff doesn't look right in the GitHub UI, but if you diff it locally you'll see that only the color values changed :)

In summary:
Great work, almost there! Just implement the suggestion and everything else should be good enough to merge :)

icons/llvm/llvm-original.svg Outdated Show resolved Hide resolved
Update colors

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greeat work @weh! ✔️ The icons look stunning! ✨
I'm interested in knowing what tool(s) you used to convert the PNG into SVG, would you be willing to share your knowledge? 🧠

@weh
Copy link
Contributor Author

weh commented Oct 7, 2022

Sure @Snailedlt

Basically my Workflow is using the Tools mentioned on the Wiki Page https://github.com/devicons/devicon/wiki/Recommended-resources-and-tools

  • Inkscape
  • Iloveimage
  • vecta.io
  1. Open PNG image in Inkscape
  2. Use the "Trace Bitmap" function to convert the Image
    image
  3. Change the Image aspect ratio to be square (size does not matter)
  4. Save image in Inkscape format (with all the "bloated" svg stuff)
  5. Resize the Image to 128x128 with https://www.iloveimg.com/resize-image/resize-svg
  6. Optimize image Size with https://vecta.io/nano
  7. Re-add the viewBox="0 0 128 128" (that gets removed by Vecta)

You may need to test the results with Trace Bitmap and tweak the params. In this Case the tricky part was the White Background. It got removed, in every variant. So i Gimp to create a "white only" version of the Image and combined both Inkscape converted Images in my IDE (or any text Editor you want).

Inkscape writes pretty good editable svg xml files. Many times i do tweak colors and similar things in the text editor.

@Snailedlt
Copy link
Collaborator

@weh neat!
I didn't know that Inkscape was that good at converting bitmap images to vector images.

Would be nice to have that step by step guide in the wiki somewhere. Maybe a separate section for How to convert PNG to SVG, or alternatively How to convert bitmap images (PNG, JPG,...) to vector images (SVG...).

Would you want to add that yourself, or should I do it?

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit ceb559c into devicons:develop Oct 11, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: llvm (original, plain)

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

* change color

Co-authored-by: David Leal <halfpacho@gmail.com>

* Add more tags

Co-authored-by: David Leal <halfpacho@gmail.com>

* Better svg version

* Switch colors

* Update icons/llvm/llvm-original.svg

Update colors

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: llvm (original, plain)

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

* change color

Co-authored-by: David Leal <halfpacho@gmail.com>

* Add more tags

Co-authored-by: David Leal <halfpacho@gmail.com>

* Better svg version

* Switch colors

* Update icons/llvm/llvm-original.svg

Update colors

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: llvm (original, plain)

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

* change color

Co-authored-by: David Leal <halfpacho@gmail.com>

* Add more tags

Co-authored-by: David Leal <halfpacho@gmail.com>

* Better svg version

* Switch colors

* Update icons/llvm/llvm-original.svg

Update colors

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants