Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: playwright (original, plain) #1437

Merged
merged 3 commits into from
Oct 11, 2022
Merged

new icon: playwright (original, plain) #1437

merged 3 commits into from
Oct 11, 2022

Conversation

oguzakif
Copy link
Contributor

@oguzakif oguzakif commented Oct 9, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1426

Link to prove your SVG is correct and up-to-date.

Snailedlt
Snailedlt requested changes Oct 10, 2022
View reviewed changes
devicon.json Show resolved Hide resolved
@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 10, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
Snailedlt
Snailedlt requested changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!
Just something I missed in the first review, that needs to be fixed

icons/playwright/playwright-plain.svg Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 10, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

Thanks for a fast and clean contribution! 💯

@Snailedlt Snailedlt requested review from a team, amacado and Panquesito7 and removed request for a team October 11, 2022 07:14
Panquesito7
Panquesito7 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you. 🚀

@Panquesito7
Copy link
Member

One question before merging: should we add wordmark versions?

@oguzakif
Copy link
Contributor Author

One question before merging: should we add wordmark versions?

I did not add it because there is no wordmark version of the logo anywhere on Playwright's site. If its needed, I can add them too.

@Panquesito7 Panquesito7 merged commit ac7f7ca into devicons:develop Oct 11, 2022
@Panquesito7 Panquesito7 changed the title new icon: playwright (original, plain) new icon: playwright (original, plain) Oct 11, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@oguzakif @Snailedlt
new icon: playwright (original, plain) (devicons#1437)
acac664 
* playwright original and plain versions are added

* altnames attribute is added to playwright

* Plain version paths combined into single path
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@oguzakif @Snailedlt
new icon: playwright (original, plain) (devicons#1437)
63769a1 
* playwright original and plain versions are added

* altnames attribute is added to playwright

* Plain version paths combined into single path
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@oguzakif @Snailedlt
new icon: playwright (original, plain) (devicons#1437)
d6e3939 
* playwright original and plain versions are added

* altnames attribute is added to playwright

* Plain version paths combined into single path
@lunatic-fox lunatic-fox mentioned this pull request Dec 9, 2022
Closed
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@amacado amacado Awaiting requested review from amacado

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oguzakif @Panquesito7 @Snailedlt