-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: bun (original) #1462
new icon: bun (original) #1462
Conversation
Bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon itself looks good, but since it's multi-colored it can't be used as a font. So either remove original
from the font array, or add a new mono-colored (plain or line) icon which can be used as a font :)
@AmreshSinha Do you want to make a plain or line version of this icon? If you don't want to, that's okey too :) We can ask someone else |
I'll do these changes today😅 I was afk for some days.
I can't think of the main color in this main logo for the plain one. :/ It would be very helpful if anyone can co-author this pr with a plain or line version. |
@lunatic-fox or @kilianpaquier |
Hello, I can take a look next Saturday |
Hello, here's a proposition for the bun original icon. |
Hi @kilianpaquier! Like preserving the mouth contour and no fill.
|
Hello ! Yes obviously I didn’t write the correct word 😂. Thanks for the feedback, I see it with the right color on my phone, but I’m gonna take a look at the attributes just to be sure. Great idea for the line icon, I shouldn’t take me long tonight to draft it. |
Pretty good! 🤩 |
@lunatic-fox feel free to add the plain and line icons to the PR. Like you said, the plain version needs the tongue added back in :) |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! ✔
Thank you for this contribution! 🚀
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1282
Link to prove your SVG is correct and up-to-date.
https://github.com/oven-sh/bun/blob/main/packages/bun-landing/public/logo.svg
Additional Comments
There was no
svg
of wordmark and plain type in their original repository.