Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: redux (original) #1594

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

lunatic-fox
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

Unify paths into one, removing fill="none" subtraction method.

This PR closes NONE

Notes

fill="none" subtraction method can lead to a solid square in final font instead of the icon.

@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jan 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jan 2, 2023
@Snailedlt Snailedlt added the bug Use this label for pointing out bugs label Jan 30, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh same issue as with #1518 , nice catch! :D
LGTM! ✔️

@Snailedlt Snailedlt merged commit 61d88be into devicons:develop Jan 30, 2023
@lunatic-fox lunatic-fox deleted the update-redux branch June 1, 2023 12:29
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger bug Use this label for pointing out bugs feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants