-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: consul (original, original-wordmark, plain-wordmark) #1604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there!
Since original
version is already a monochromatic icon I took the liberty to remove plain
version and aliased original
as plain
in devicon.json
. Hope that's ok! 😁
I also suggesting two more tags security
and tool
.
You've made a great pull request! 🚀
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Hey @lunatic-fox, I think I added all the requested changes. Also, the suggestions you made about original version being already a monochromatic icon and making alias of original as plain in devicon.json apply to another PR that I made #1609. I've dedicated myself to contributing good quality icons, is there anything that could be better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @luizcarloscf, perfect catch on your other PR.
Well, I think you're already doing a great job. If you want to get more specific info you can take a look at SVG Versions and Updating devicon.json
wiki topics.
There's also the Devicon Discord server.
A little thing about GitHub is that is possible to commit someone's suggestion this way:
Thank you for this contribution! ✔🚀
The icons are excellent! 💯 I think the only thing to make them better is to add a new line at the end of each file, since it's needed for some older text editors and IDE's. |
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
- Add newline at the end of each file - Scale icons to fit in viewbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resizing looks good, however there are now two newlines instead of one at the end of each file. It's a bit confusing since GitHub automatically hides the last newline, but if you edit the file, you'll see that there are 2 empty lines at the end.
So make sure there's only one newline at the end of each file :)
That's kind odd, I opened with a text editor and I saw only two lines in the SVG files. I will check this... |
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
I opened the icon files with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! ✔
Thank you for this great contribution! 🚀
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thanks for another great PR, and thank you for making our review process easy by having high quality PR's! |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1603
Link to prove your SVG is correct and up-to-date.
Project Homepage
HashiCorp Brand Guidelines
Logo