Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: helm (original, line) #1618

Merged
merged 6 commits into from
Jan 18, 2023
Merged

update icon: helm (original, line) #1618

merged 6 commits into from
Jan 18, 2023

Conversation

ConX
Copy link
Contributor

@ConX ConX commented Jan 8, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This PR closes #1613

Notes

@ConX ConX mentioned this pull request Jan 8, 2023
Closed
1 task
@lunatic-fox lunatic-fox changed the title Update HELM icons, color, and add line icon update icon: helm (original, line) Jan 8, 2023
lunatic-fox
lunatic-fox requested changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello again @ConX!

I've removed plain version, because the original is a monochromatic icon that can be aliased as plain.

I need that you resize both versions to 128px squared icon, then optimize them.

The reason for the alert on Icomoon, as it said, was because the previous icons have a lot of strokes and other unnecessary style information. So, thank you for noticing that and have made this pull request. 😁

@lunatic-fox lunatic-fox added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jan 8, 2023
@lunatic-fox lunatic-fox requested a review from Snailedlt January 8, 2023 23:47
@ConX
Copy link
Contributor Author

ConX commented Jan 9, 2023

Hi @lunatic-fox, I resized the icons to 128x128px and ran svgo to optimize. Let me know if there is anything else needed.

Thanks for explaining the reasoning on whether an icon needs the plain or not.

@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

lunatic-fox
lunatic-fox approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔
Thank you for this contribution! 🚀

Snailedlt
Snailedlt approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! ✔️

@Snailedlt Snailedlt merged commit 96d3742 into devicons:develop Jan 18, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@ConX @lunatic-fox
update icon: helm (original, line) (devicons#1618)
672b143 
* Update HELM icons, color, and add line icon

* Update helm-line

* Update helm-line with 3pt line

* Remove `plain` version and update `devicon.json`

* Resizing to 128x128 and optimize with svgo

* Adjustments to icons

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConX @Snailedlt @lunatic-fox