Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: readthedocs (original, original-wordmark, line) #1630

Merged
merged 7 commits into from
Mar 16, 2023
Merged

new icon: readthedocs (original, original-wordmark, line) #1630

merged 7 commits into from
Mar 16, 2023

Conversation

ConX
Copy link
Contributor

@ConX ConX commented Jan 14, 2023

Double-check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://read-the-docs-guidelines.readthedocs-hosted.com/branding.html#logo-guidelines

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jan 18, 2023
devicon.json Outdated Show resolved Hide resolved
@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jan 27, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what @lunatic-fox already commented, this looks good to me :)

devicon.json Outdated Show resolved Hide resolved
ConX and others added 4 commits March 15, 2023 23:07
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Based on @Panquesito7 feedback

Co-authored-by: David Leal <halfpacho@gmail.com>
@ConX
Copy link
Contributor Author

ConX commented Mar 16, 2023

@Snailedlt, this should be ready to merge

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✔
Thank you for this contribution! 🚀

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ✔️
Thank you for another great contribution! 💯

@Snailedlt
Copy link
Collaborator

@ConX @lunatic-fox any idea why the optimize icons check is failing?

@lunatic-fox
Copy link
Contributor

@ConX @lunatic-fox any idea why the optimize icons check is failing?

I was about to comment it later. 😄
I think is something related to repository permissions, because the exit 128 response when the bot tries to commit.
I think if is something that's not possible to fix now, I should probably make a PR to remove this feature at moment.

@Snailedlt
Copy link
Collaborator

@lunatic-fox aha! So probably the same issue as with the in-develop labeler then? See #1410

@Snailedlt
Copy link
Collaborator

Anyways, this should be safe to merge now, right @lunatic-fox ?

@lunatic-fox
Copy link
Contributor

Anyways, this should be safe to merge now, right @lunatic-fox ?
Sure! 👍🏼

@lunatic-fox lunatic-fox merged commit 8534f89 into devicons:develop Mar 16, 2023
@ConX ConX deleted the new-icon-readthedocs branch March 28, 2023 06:18
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants